[01:03:07] puppet does have loops but only with parser=future: https://docs.puppet.com/puppet/3.5/reference/function.html#each [16:23:49] bd808: Do we have it written down somewhere how to cherry-pick puppet changes to deployment-prep? It's been a while and I forgot the procedure, even if I assume it hasn't changed since the last time. [16:24:04] we do... let me find it [16:25:21] anomie: https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/How_code_is_updated#Cherry-picking_a_patch_from_gerrit [16:26:19] deployment-logstash2.eqiad.wmflabs is the host you'll want to force the puppet run on [16:27:13] Yeah, I was using that one for testing with a logstash instance configured to read stdin and write stdout. [19:19:05] bd808 I am applauding https://www.mediawiki.org/wiki/Manual:Structured_logging for which your initial revision has the comment: (get this out of my head and on wiki) [19:21:24] brain storage is horrible for collaborative editing [19:26:09] bd808: so essentially whenever I see something like wfDebugLog("some $horrible construct $that is not friendly to machine"); [19:26:46] I can do something like $logger->debug( "some {horrible} construct", [ 'horrible' => '777' ] ); [19:27:09] yup [19:27:10] and logstash will be hapilly dedupe the message + save "horrible = 777" ? [19:28:05] hashar: yeah. the de-dup magic is https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/logging.php#L64-L91 [19:28:37] ah yeah a factory having an anonymous function which returns... a function [19:28:43] that looks like javascript to me :( [19:28:52] neat thanks for the pointer [19:36:56] AaronSchulz: I'm getting exceptions: Uncaught exception 'DBUnexpectedError' with message 'Foreign domain connections are still in use (commonswiki).' when running unit tests on my vagrant [19:37:00] any idea why? [19:38:23] SMalyshev: which test fails? [19:38:38] AaronSchulz: tests do not fail, this happens after the tests finish [19:39:01] AaronSchulz: regardless of which test I run. Test itself works but then I get fatal error [19:39:41] AaronSchulz: here's backtrace: https://phabricator.wikimedia.org/P4125 [20:17:05] AaronSchulz: any ideas? This seems to be happening only when running unit tests from Cirrus extension, not from core [20:57:48] SMalyshev: you mean using the test file name as an argument? [20:58:54] AaronSchulz: well yes that happens when I run single test [20:59:17] e.g.: php tests/phpunit/phpunit.php --wiki=wiki --stop-on-failure extensions/CirrusSearch/tests/unit/SearcherTest.php [20:59:31] (happens with any test) [20:59:35] yeah, lots of missing calls in GU [21:00:03] AaronSchulz: so I made https://phabricator.wikimedia.org/T146811 - I suspected it's something in GU [21:17:14] SMalyshev: just posted a patch [21:19:27] AaronSchulz: tried it on my setup, exception still there [22:38:35] SMalyshev: do they pass if you disable GU? [22:38:57] AaronSchulz: they pass in any case, the exception happens after the tests are done [22:39:23] erm, "pass" isn't the right word, I mean does the error happen if it's off? [22:39:27] AaronSchulz: I'm not sure how to disable GU properly, but I'll try, give me a sec [23:23:57] 10MediaWiki-Core-Team, 10MediaWiki-API, 10MediaWiki-User-login-and-signup, 06Wikipedia-Android-App-Backlog, and 2 others: Support login with email address as well as with username - https://phabricator.wikimedia.org/T88046#2672505 (10Josve05a)