[08:33:18] bd808: merged, sorry about the delay [09:12:24] bd808: re https://wiki.mozilla.org/Add-ons/Extension_Signing , yeah that is since firefox 49 and that prevents one from using the Selenium web driver :-( [09:13:14] tldr: gotta sign your extension :D [17:34:32] "Judging by the way your add-on works and is described, we believe that it shouldn't be listed on AMO. You can submit the add-on as unlisted instead, so it is signed for self-distribution. You can find more information about this here: https://developer.mozilla.org/en-US/Add-ons/Distribution" -- fuck you Firefox [18:00:54] wat [18:12:02] ori: apparently since they finally have a remote signing api they are increasingly kicking extensions out of their public index? I replied to their email asking for clarification (and spreading "Chrome is easier to use" FUD) [22:08:49] ostriches: how do I delete an unused Gerrit repo? I want to partially usurp it's name [22:10:41] [b14fc8dbd4c23c7df2222184] /mediawiki_dev/w/api.php?action=visualeditor&format=json&paction=wikitext&page=Main_Page&uselang=en-gb Error from line 2755 of /home/alex/Development/MediaWiki/includes/api/ApiBase.php: Call to undefined method ApiResult::getData() [22:10:52] anomie... [22:13:33] legoktm you carn't [22:13:47] legoktm you can make it read only, or hide it i think [22:13:56] no, there's a way to delete it [22:14:08] legoktm https://gerrit.googlesource.com/plugins/delete-project/ [22:14:13] but we doint have that installed [22:14:31] hm [22:14:32] https://wikitech.wikimedia.org/w/index.php?title=Gerrit&type=revision&diff=819250&oldid=819246 [22:14:33] I see [22:14:33] or you just delete the .git folder on the lead machine, for example mediawiki/core is core.got [22:14:42] okay [22:14:43] thanks [22:15:08] Ugh, no do not just delete it on disk. [22:15:21] You have to do that, plus clean up the DB [22:15:31] Oh [22:15:36] mediawiki/core is obviously the best example to use when showing how to completely delete repositories [22:15:39] There's a reason I removed the plugin--it's way too destructive and impossible to undo. [22:15:58] yep [22:16:13] alright [22:16:21] I marked it as hidden [22:16:25] If the old repo is unused, just "steal" it lol [22:16:25] :) [22:16:26] ;-) [22:16:29] lol [22:17:05] ostriches: it was called "timestamp" but we're now using mediawiki/libs/ so I created a new repo but need to take the old github name [22:18:03] Wait, this was to move the existing repos? I said no to that.... [22:18:06] * ostriches shrugs [22:18:36] nonono, the repo was never used [22:18:53] and only creating new ones in that namespace, leaving the old ones as they are [22:19:15] bah, gerrit namesapces [22:19:20] Oh, then yeah just make it read-only [22:19:30] pseudo namespaces at that! [22:20:10] the nice thing is that because it's under mw/ I don't have to fiddle with access lists or granting permissions to push signed tags each time [22:20:25] You don't anyway ;-) [22:20:30] Parents are arbitrary! [22:20:41] foo/bar can inherit from baz/bam [22:20:44] You certainly can't choose them ;) [22:20:59] foo/bar also doesn't automatically inherit from foo/ [22:21:08] Default parent is All-Projects ;-) [22:21:29] openstack-wikistatus inherited from operations/debs [22:21:49] sink_nova_ldap and sink_nova_fixed_multi inherited from openstack-wikistatus [22:21:52] why is some random dude adding mediawiki and wikimedia as co-maintainers on packagist? [22:22:25] ah... things that are moving to gerrit looks like [22:22:30] ... [22:22:37] https://packagist.org/packages/hallowelt/blue-spice-foundation [22:22:42] I'm going to pretend I didn't learn that and still think some parts of Gerrit are sane [22:23:00] hallowelt has contracted for WMF before I think? [22:23:10] OH, i was added there [22:23:11] too [22:23:12] legoktm, the three repositories I mentioned are all ones I've killed within the past few weeks [22:23:19] nice :) [22:23:20] well, I mean [22:23:22] they still exist [22:23:25] they just aren't used [23:12:10] hi AndyRussG! [23:12:16] robla: hey! [23:12:38] we were just talking about a caching problem that I'm hoping someone here can help us with [23:12:42] * AndyRussG enjoys the discovery of a previously unvisited channel [23:13:13] the bug: https://phabricator.wikimedia.org/T144952 [23:13:49] robla: another indication that there's some caching option or setup issue was that at one point, awight was getting all good responses, then exactly 10 minutes (after creating the banner? or editing it? not sure) the messages started turning up empty [23:14:14] that sounds like one of those ObjectCache options that're supposed to prevent cache poisoning via race conditions [23:14:56] i.e., after a key has been invalidated, don't start storing it and force DB lookups for a certain time, to avoid race conditions due to DB slave lag [23:15:52] robla: another possible clue is that we just got a couple reports (maybe the same bug) of user-facing errors related to banners. I mean, could be related, might not tho [23:15:58] this is the type of problem that I would frequently have said "AaronSchulz, halp!", and I'm kinda doing now, but I think this is "anyone, halp!" :-) [23:16:09] (just getting the phab links...) [23:16:47] :) [23:17:40] https://phabricator.wikimedia.org/T147002 [23:17:48] * robla looks [23:19:07] https://phabricator.wikimedia.org/T146880 [23:22:06] I haven't started digging into those at all... [23:23:43] I confess the TranslationExtension-linked corner of this codebase is one that I have rarely worked on... [23:23:49] and so don't know as well as others [23:25:33] I'm trying to get my head back around how these systems work, and that's making me a little slower than I should be in asking questions [23:26:53] so....the banners are stored in the ObjectCache, which (as I recall) an abstraction around our memcached setup. Am I getting that right? [23:26:54] robla: all good! I'll be here for about 4 more hrs [23:27:20] I believe so. I mean, it must be, since that's where we get them from [23:27:28] But I haven't discovered exactly what code writes them there [23:27:49] They are basically Mediawiki: namespace pages [23:28:45] AndyRussG: it might be helpful for us to get on a quick phone call/hangout/whatev, and then I can summarize our discussion here. Available for that? [23:29:27] Yeah! one minute then :) [23:29:37] Here's the CN code that writes the content: https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/731d248f7d7c9a265193500d41fced0fa691de39/includes/Banner.php#L759-L791 [23:29:51] * AndyRussG tries to hide cruft of unknown origin under the carpet [23:30:08] here's the hangout I just created: https://hangouts.google.com/hangouts/_/wikimedia.org/cache [23:31:21] * robla prepares to try outdoing a rubber duck, and is worried he won't succeed ;-) [23:40:28] Here are some of the layers, https://www.mediawiki.org/wiki/Localisation#Caching [23:42:12] awight: if u feel like hangouting, see ^ [23:48:53] AndyRussG: pull me in if I might be helpful with something--I'm currently messing with a queue-related thing (reviewing ejegg's damaged message ui) otherwise [23:49:28] awight: k thanks I'll let u know, havefun! [23:49:41] all I know is that I found a 10-minute artifact with 0-100-0% edges [23:50:22] awight: yeah maybe when u have a chance it'd be nice to know more exact circumstances in which that arose? don't let me distract u too much just now, thx again [23:53:03] robla: AndyRussG: https://phabricator.wikimedia.org/T144952#2672822 [23:53:53] robla: AndyRussG: https://github.com/wikimedia/mediawiki/blob/master/includes/cache/MessageCache.php#L145-L163