[15:11:40] anomie: lol. I guess I wanted better smelling rate limit checks :) [15:13:51] bd808: I forgot about fixing the typo and just merged it, didn't I? [15:14:44] yeah. I don't think the world will end though. Not the first time I've had typos in a commit message by far [15:15:18] I wasn't intending to be like "ha ha, typo, merged!" [15:29:12] ori: hi, got 15 minutes to spare to review https://gerrit.wikimedia.org/r/313238 "Make Special:MIMESearch non-expensive, again"? it reverts your commit from a couple months ago [16:14:46] anomie hi, im wondering if you could help me with https://phabricator.wikimedia.org/T138168#2688986 please? [16:14:58] Patch is https://gerrit.wikimedia.org/r/#/c/312327/ [16:15:04] which i have applied, since im testing [16:15:20] but should have nothing to do with the login problem. [16:37:51] or tgr|away ^^ [17:58:22] Krinkle: https://gerrit.wikimedia.org/r/#/c/309766/ really needs someone experienced with javascript to say whether it's reasonable, or whether i've made the whole thing too complicated [18:03:47] MatmaRex: Seems reasonable at first. [18:06:02] Krinkle: thanks. wanna give it a second look and merge if it still looks reasonable then? ;) [19:20:15] csteipp: is MWCryptHKDF actually used for anything? [19:21:25] legoktm: No. I originally planned to use it in centralauth. Then I was going to use it instead of the time-based prng for windows computers, but I don't think it's being used anywhere. [19:22:46] legoktm: The windows clock drift code is pretty horrible, and means we can't do heavy random number generation. So it would be good to eventually replace it. [19:23:01] ok, so we should still keep it around? [19:23:18] ^ "can't... without screwing windows users, if we want to claim to care about them" :) [19:23:28] Unless it's causing problems. [19:24:17] nah, I was refactoring it to be reusable outside of MW (https://gerrit.wikimedia.org/r/#/c/314041/) and then couldn't find anything that used it to test with [19:24:24] Or... maybe deprecate it for a version, and then either plug it into MWCrypt or pull it out. [19:24:42] hah, ok [19:47:22] anomie: machine is tired, i think i need to reboot.... [19:47:28] dr0ptp4kt: ok [19:48:02] anomie: anyhow, good talking with you. until next time... [19:48:07] also, csteipp ! [19:49:22] * csteipp waves [23:05:27] wikitext gurus: what is the right way to link from a page to "view seource" of the same page, in wikitext? [23:06:15] external link I think [23:06:52] Reedy: what kind of external link? I want it to automatically compose the URL, is it possible? [23:07:20] something like {{thispage_url|action=view}} or something... [23:07:34] {{fullurl:{{PAGENAME}}|action=edit}} [23:07:40] [{{fullurl:{{PAGENAME}}|action=edit}} Link text] [23:07:47] yeah, that [23:08:09] aha, thanks [23:08:24] There's no way to show the source, but without edit? [23:08:49] action=raw&ctype=text/css [23:08:54] lol [23:08:55] you want action=raw maybe? [23:09:08] but that has no interface at all. just the contents [23:09:11] "View source" is only shown when you don't have enough rights [23:09:28] action=edit will show the source, with no way to save changes, if you can't edit the page [23:09:55] ah, but I can't force this view, right? [23:10:21] ok, I'll use edit then, thanks! [23:11:41] Will someone +2 https://gerrit.wikimedia.org/r/313756 please? it's for REL1_27, already merged on master [23:20:44] ty ori :D