[12:58:11] Reedy hi, im wondering weather to switch on $wgPingback [12:58:15] I just found the setting [12:58:26] Will this setting be used for an updater built into mw? [12:58:40] IE update mw, when ever there is a release [13:02:29] It's already used if enabled [13:08:32] Oh [13:08:52] Reedy can it tell you when an update is available or is that still to be implemented? [13:09:02] What? [13:09:59] Reedy well it sends your server info such as php version, mw version [13:10:13] Yes? [13:10:18] So that sounds like they are preparing a mw updater, so users can be notifyed and download the update [13:13:09] Reedy could you review https://gerrit.wikimedia.org/r/#/c/310341/ and https://gerrit.wikimedia.org/r/#/c/310342/ please? [13:13:34] There's various bugs about it [13:13:42] Oh [13:21:11] Reedy do you know how i can apply for something that allows my saves to automatically be shown without waiting or approval? [13:21:19] Oh never mind [13:21:23] this is translation [13:21:24] This page contains changes which are not marked for translation. [13:21:38] Oh i guess for translation then? [14:07:45] paladox/mediawiki#1 (patch-1 - 7435708 : paladox): The build has errored. [14:07:46] Change view : https://github.com/paladox/mediawiki/compare/86f4e634e1f4...743570825c74 [14:07:47] Build details : https://travis-ci.org/paladox/mediawiki/builds/167883459 [14:18:27] Reedy do you know if postgres is installed on ci? [14:18:41] I want to setup a mw test that test against postgres [14:18:50] To prevent regression and breaking postgres [14:18:52] please [14:18:53] ? [17:02:21] Reedy hi, could you review and merge https://gerrit.wikimedia.org/r/#/c/316075/ please? [17:06:05] Why are there so many reviewers on it? [17:10:19] Since, i doint know who will review it. [17:15:12] Reedy for postgres i also found https://github.com/wikimedia/mediawiki/commit/a26fbb67054a09e80ac7e59c1a9f351474649a1e [17:15:21] Which was unrelated to what i was doing [17:15:28] but came accross it when trying something [17:41:41] Reedy i guess using explicit transaction in postgres works [17:41:54] I get a little furthur, now i need to see weather changing the other files will work [21:26:32] Reedy hi, do you know if we have to do this https://github.com/wikimedia/mediawiki/blob/259c79579a6a8c5b3564632b1497a4f9b9f2e9c6/includes/installer/PostgresInstaller.php#L609 [21:26:34] for postgres [21:26:40] or can we do it diffitly? [21:26:46] It fails the postgres test [21:26:47] with [21:26:55] 209PHP Fatal error: Call to undefined method DatabasePostgres::getSchemaPath() [21:26:59] https://travis-ci.org/paladox/mediawiki/jobs/167926828 [21:27:20] Add it then? [21:28:32] Oh [21:28:48] Reedy but it exist in DatabaseInstaller [21:29:00] Should i just duplicate [21:29:53] As far as I can see, none of the other db layers call getSchemaPath anymore [21:30:18] I see no sign of table creation in them [21:30:44] So, I guess you call the one that's in the installer then? [21:31:40] DatabaseInstaller has... [21:31:40] public function createTables() { [21:31:41] return $this->stepApplySourceFile( 'getSchemaPath', 'install', true ); [21:31:41] } [21:31:45] Oh, yep [21:32:17] so it is unneded? [21:33:29] There's presumably a reason the postgres installer overrides it [21:33:31] Reedy so i should just remove https://github.com/wikimedia/mediawiki/blob/259c79579a6a8c5b3564632b1497a4f9b9f2e9c6/includes/installer/PostgresInstaller.php#L611 that part [21:33:32] ? [21:34:10] well, not if you want it still create the tables [21:34:14] Oh [21:34:48] I replaced it with something like $error = $conn->sourceFile( "path/to/postgress/tables.sql" ); [21:35:06] But that failed, since when it was creating the tables, it said something about duplicates [21:35:10] does it something like work? [21:35:17] See https://github.com/wikimedia/mediawiki/pull/57/files [21:35:24] Reedy it gets furthur [21:35:30] But fails now at sql [21:36:23] paladox: why in the heck are you making a pull request on github? [21:36:37] bd808 im trying postgres [21:36:44] wikimedia ci dosent have postgres [21:36:53] and you aren't capable of setting it up for local testing? [21:37:04] No, since i doint know how postgres works [21:37:09] if not I think you may have a hard time writing the correct code [21:37:12] Well, why are you trying to fix it? [21:37:34] Since it is broken and https://phabricator.wikimedia.org/T147599 showed the commit that broke it [21:37:42] but it seems to be more broken then that commit [21:37:55] I love that you are helping, but there comes a point where you are waisting other peoples time with your random guesses [21:38:32] Yes sorry, but no one seems to be working on it, so we will ship postgres broken when mw is released. I thought it would be easyer then this but it isen't [21:38:44] It's been broken on and off for years [21:39:15] I really wish we would have finished the RfC to move everything other than MySQL out of core [21:39:21] Oh [21:39:21] lols [21:39:38] bd808 that actually was discussed for mssql [21:39:50] we don't do the right thing for most of the other DB backend mostly because they get very little testing [21:40:18] bd808 im about to see if i can setup a patch [21:40:23] that adds the support in ci [21:40:42] since sqlite works in wikibase but no other extension or other repos have access to the test [21:40:45] well you will need to learn how to install and configure postgres first [21:41:02] and then you will need to learn how to write puppet modules to manage that [21:41:12] bd808 see https://phabricator.wikimedia.org/T113831 [21:41:27] people didn't like that idea [21:41:35] and then you will need to justify the servers needed to run it and then extra time to run all the db tests against yet another backend [21:41:56] bd808 theres a task in ci about this [21:42:02] Just hasen't been worked on yet [21:43:19] sure. there are tasks for many things. you already said you don't know how postgres works though [21:43:40] so I'm unsure how helpful your help with this particular task will be [21:44:21] I'm not trying to drive you away, but maybe you should find something that is broken that you can reason about more completely [21:44:39] Ok [21:45:56] Another way you could help with postgres issues would be to write to wikitech-l looking for postges users and admins willing to help fix up the issues that MediaWiki has with that db [21:46:08] Oh yep [21:46:09] thaks [21:46:11] thanks [21:48:40] DOne [21:48:47] It may go to gmail spam box [21:48:50] since i used yahoo [21:48:54] bd808 ^^ [21:49:12] heh. poor yahoo [21:49:49] Yep, i have no idea too why it goes into every ones spam box [21:54:43] bd808 i found one postgres develepor https://www.mediawiki.org/wiki/User:Turnstep [21:54:47] develeper [21:56:35] I've not seen them do any MW pg patches recently [21:57:43] Reedy nope, but is active in phab [21:58:40] Have they actually made any patches to mw core? [21:58:45] It's not a name I recognise [21:59:36] Reedy yes [21:59:43] Made many patches to postgres [21:59:53] according to the history for maintenance/postgres [22:14:13] paladox/mediawiki#20 (master - 0557c52 : paladox): The build has errored. [22:14:14] Change view : https://github.com/paladox/mediawiki/compare/93cd933c1675...0557c52aaa86 [22:14:14] Build details : https://travis-ci.org/paladox/mediawiki/builds/167958095 [22:18:39] bd808 actually i can [22:18:44] test postgres [22:18:50] using my windows ubuntu on bash [22:19:08] Seperate from windows, i can then quickly install postgres [23:55:56] bd808 nope postgres currently has problems on wsl so im going to see if i can install postgresql windows side and have wsl connect to it [23:58:30] https://github.com/Microsoft/BashOnWindows/issues/61