[14:18:30] No phpcs sniff for "function(" versus "function ("? [14:18:39] heh [17:55:16] I am reviewing wmf wiki/db visibility [17:55:27] I am trying to indetify all public wikis [17:55:45] jynus: all.dblist - private.dblist [17:55:46] "sort all.dblist private.dblist private.dblist | uniq -u" [17:55:59] yes, anything else I should know? [17:56:07] for example, how are closed wikis managed? [17:56:16] how? [17:56:25] there's a closed.dblist ;) [17:56:42] but what is its relationship with the others? [17:57:01] as in, what is the meaning that a wiki is closed, that we cannot edit it anymore? [17:57:06] yes [17:57:13] but it is fully public [17:57:20] unless it is on private, right? [17:58:07] Sounds right... There's only a couple on closed that might be questionably not open [17:58:18] But at least some of those aren't even web accessible now [17:58:23] ok [17:58:25] that is important [17:58:36] let's continue talking somewhere else [19:49:16] ugh [19:49:18] $ git review --version [19:49:18] git-review version 666 [20:14:02] anomie: file a bug plz? :) [20:20:20] anomie: also, do you have any ideas about https://phabricator.wikimedia.org/T149473? [20:21:40] * anomie looks [20:30:09] legoktm: The main problem is that EditPage.php line 1675 should call ->getWikiText, not ->getHTML. A secondary problem is that random wikis' customized messages that are applying a box are now going to be wrapped in the red error box too.