[01:43:13] Krinkle: I don't use Chrome, but haven't seen anything about global.js not working reliably [17:09:43] ostriches: folks want me to backport https://gerrit.wikimedia.org/r/#/c/309575/ to 1.27. what is the current process for this? [17:10:05] You cherry pick to REL1_27 and merge [17:10:06] {{done}} [17:10:46] ostriches: okay… so i guess that'll make it included in the next security release? [17:11:01] Anything in the branch will be in the next release yes [17:11:25] alright, i'll do that then. thanks [17:43:52] MatmaRex: IMO T150454 is a bug in the OOjs-UI merge-into-MediaWiki release process if nothing else. [17:43:52] T150454: ApiSandbox is broken - https://phabricator.wikimedia.org/T150454 [17:56:15] anomie: perhaps, but it's still not a bug in OOjs UI. [17:56:32] (perhaps the breaking change should have been announced more than once. perhaps it should've been outputting warnings.) [17:56:50] (for the record, the next breaking change we're planning is outputting warnings right now.) [17:57:25] (it was announced in "[Wikitech-l] OOjs UI 0.13.0 Release (breaking change)" on 2015-11-02) [18:31:07] anomie: can you give a quick +1 to https://gerrit.wikimedia.org/r/#/c/320552/ / https://gerrit.wikimedia.org/r/#/c/320450/ so I can put them to SWAT? [18:36:50] tgr: Done. [18:36:59] thx [18:47:55] bd808: can we backport your CREDITS patches to 1.28? or are they based on 1.29? [19:26:46] AaronSchulz: thanks for "CryptRand: remove newlines from logging message [core]" - https://gerrit.wikimedia.org/r/320784 [19:26:47] :) [20:46:29] anomie: hmm, grepping for "api.php?" finds tons of broken examples...has it always been broken or was it changed recently? [20:47:03] broken that they don't return any results? [20:47:17] Or completely broken so that they would never//completely wrong queries? [20:47:23] er no https://gerrit.wikimedia.org/r/#/c/320524/ [20:47:23] legoktm: getExamples() should have "api.php?". Only getExamplesMessages() needs to lack it. [20:48:09] ah [20:49:18] getExamples() is also deprecated since 1.25. [20:49:19] anomie: do you want to send an email to wikitech-l so people have a heads up if their extension tests start failing? or did you check all of them? [20:50:20] I don't remember if I checked all extensions or just deployed extensions, but I can check again quickly enough. [20:50:40] that would be appreciated :) [20:53:42] legoktm: Apparently I only checked deployed extensions. Broken extensions: ShoutWikiAPI Snippet MediaWikiChat [20:54:53] anomie: also [12:54:25] (PS1) Legoktm: Only check isInGeneratorMode() on instances of ApiQueryGeneratorBase [extensions/ORES] - https://gerrit.wikimedia.org/r/320843 [21:00:22] legoktm: I fixed those three extensions and added you as a reviewer. [21:00:27] thanks [21:00:33] will look in a few minutes [21:12:05] I updated https://www.mediawiki.org/w/index.php?title=API%2FArchitecture_work%2Fi18n&type=revision&diff=2281689&oldid=2272338 too [21:18:00] legoktm: Looks like https://gerrit.wikimedia.org/r/#/c/320846/ isn't set up to run Jenkins. [22:31:18] legoktm: they were written in 1.28 branches