[02:31:08] <Reedy>	 anomie: tgr|away Is there an authmanger-y way of doing https://phabricator.wikimedia.org/T131124 ?
[02:36:47] <tgr>	 Reedy: I think this already happened; SpecialOATHLogin is not used with AuthManager
[02:37:15] <tgr>	 and SpecialOATHEnable/SpecialOATHDisable don't really need proxying as far as I can see
[02:37:54] <tgr>	 I have an abandoned patch to get rid of them completely
[02:38:16] <Reedy>	 I was just about to ask if I should've killed them in https://github.com/wikimedia/mediawiki-extensions-OATHAuth/commit/e38c68c13e766cb9027a1ae4f411ade8594a586b
[02:38:24] <tgr>	 https://gerrit.wikimedia.org/r/#/c/294861/
[02:39:23] <tgr>	 it needs a fair amount of work though and I don't feel much motivation to finish it anytime soon (if it's not broken...)
[02:40:00] <Reedy>	 Should the Login page have been removed already?
[02:40:42] <tgr>	 hm, yeah, I think it should have been included in that patch
[02:41:01] <Reedy>	 Cause I'm looking at chris' suggestion of "just using a callback"
[02:41:11] <Reedy>	 but doing 		$wgSpecialPages['OATH'] = function() use ( $wgRequest, $wgUser ) { }
[02:41:16] <Reedy>	 just feels kinda awful
[02:43:38] <tgr>	 yeah as far as I can see https://github.com/wikimedia/mediawiki-extensions-OATHAuth/commit/e38c68c13e766cb9027a1ae4f411ade8594a586b#diff-e07a2abf3739dfa1216c860e3254c7ae L75-77 was the only way to reach that page
[02:45:48] <Reedy>	 https://github.com/wikimedia/mediawiki-extensions-OATHAuth/blob/master/special/SpecialOATH.php#L21-L34 ?
[02:46:24] <tgr>	 there is no reachable code anymore that would set oath_login
[02:47:06] <tgr>	 well, no unreachable one eithe, SpecialOATHLogin just clears it
[02:48:03] <Reedy>	 let me create a cleanup patch
[02:48:07] <Reedy>	 and I'll test it later
[02:49:25] <Reedy>	 (ie not at nearly 3am :))
[02:49:36] <Reedy>	 Thanks tgr
[02:49:37] <Reedy>	 https://gerrit.wikimedia.org/r/321091