[06:01:53] bd808: would you have time to review https://gerrit.wikimedia.org/r/#/c/323099/ before the train goes out? it prevents the key conflict logspam that would otherwise occur at every login [15:05:00] bd808: "49% disagree that documentation is easy-to-find. Down from 52% last year." is confusing. All the other things we'd like to be 100%, but the way it's phrased we'd want that one at 0%. [15:48:06] anomie: yeah... I was trying to stick with the wording I used in the analysis last year. At that time I used agree/disagree based on the majority opinion expressed. [20:57:57] Do we have a standard which markup should be used for text docs in the source? wikitext, md, anything goes? [20:59:45] SMalyshev: plaintext or wikitext usually. [20:59:54] ok, thanks [20:59:54] See stuff like docs/* [21:00:36] it's not really consistent there... :) but I can do wikitext [21:05:39] Consistency? You must be new here ;-) [21:17:12] SMalyshev: If you want it to be seen as definitely-text, label it ….txt; a bunch of people assume (wrong IMO) that text files not so-named must be wikitext. [21:17:33] Because obviously MediaWiki's wikitext is a compelling file storage format. ;-) [21:19:20] James_F: Obviously! [22:20:37] tgr: About? https://gerrit.wikimedia.org/r/#/c/321938/ [22:20:53] Reedy: o/ [22:21:04] Fancy looking over that again please? [22:21:14] I'll deploy it as part of the security window if it's reasonable [22:23:14] Reedy: wmgPrivilegedGroups doesn't include global ones, does it? [22:23:35] looks fine other than that [22:23:42] aha.. [22:25:59] Hmm... So we don't need that for oathauth.. But we do for the logging [22:26:40] yeah, you could just list them inside wfGetPrivilegedGroups [22:27:43] founder, sysadmin, steward, global-interface-editor, global-sysop, obudsman, staff [22:29:19] new-wikis-importer has editinterface [22:30:08] maybe abusefilter-helper if we care about AF access [22:31:10] 'abusefilter-helper', 'founder', 'global-interface-editor', 'global-sysop', 'new-wikis-importer', 'obudsman', 'staff', 'steward', 'sysadmin' [22:31:49] looks right [22:32:11] there is a typo in ombudsman [22:32:57] heh [22:33:34] PS6 [22:36:51] +1 [22:37:31] Thanks [22:37:35] I'll ship it then [23:06:52] tgr: lol [23:06:53] 2016-11-28 23:05:36 [WDy4PwpAEK8AAGt-ZesAAABJ] mw1220 mediawikiwiki 1.29.0-wmf.3 exception ERROR: [WDy4PwpAEK8AAGt-ZesAAABJ] /w/index.php?title=Special:UserLogin&returnto=MediaWiki BadMethodCallException from line 1516 of /srv/mediawiki/wmf-config/CommonSettings.php: Call to a member function getGroups() on a non-object (null) {"exception_id":"WDy4PwpAEK8AAGt-ZesAAABJ"} [23:07:40] $user doesn't exist [23:07:44] d'oh [23:08:35] I'll just pass in user too for ease [23:12:55] #til about Rebase If Necessary as a merge strategy. It's like the best of both worlds. [23:13:13] Basically, rebase automatically before merging. It's like merge-if-necessary but keeps your history clean. [23:15:46] It's like "Fast forward" but automates the "dammit, I gotta click rebase" [23:15:50] "If the change being submitted is a strict superset of the destination branch, then the branch is fast-forwarded to the change. If not, then the change is automatically rebased and then the branch is fast-forwarded to the change." [23:21:05] ostriches: oh that sounds nice [23:22:11] I swapped mediawiki-config to use it instead of FF-only [23:22:15] We'll see how it works in practice. [23:24:53] ostriches: Oooh, nice.