[01:07:03] tgr: oh, I didn't realize you were waiting on me [01:07:43] I should, yes [01:08:01] legoktm: well, waiting for the fundraiser to end, mostly [01:09:41] but I'd like to hear your opinion on whether the assumptions about what parameters to expose in the interface / API are reasonable [19:27:57] bd808: [19:27:58] vagrant@mediawiki-vagrant:~$ mwscript createAndPromote.php wiki Ed --sysop [19:27:58] wiki: Creating and promoting User:wiki into sysop... [19:27:58] done. [19:28:06] broken mwscript argument parsing? [19:45:25] csteipp_, AaronSchulz: (also pinging tgr|away) Hmm. It seems AuthManager accidentally dropped passing anything for the $purpose you added to UserPasswordPolicy in https://gerrit.wikimedia.org/r/#/c/224658/, and I don't see any hooks that care about it. T104615 certainly hasn't been reopened. Since UserPasswordPolicy is already designed to differentiate login versus create/reset in whether the Status is OK or not, the parameter seems pointless to [19:45:25] me and I'd rather just remove it entirely since it was only added to try to work around a bug that was better fixed in other ways. [19:45:25] T104615: Some account creations causing exceptions - https://phabricator.wikimedia.org/T104615 [19:59:28] Krenair: looks likely. Maybe in the multiversion wrapper more than in mwscript itself [20:00:05] there is a hack in there to let an mw-vagrant farm with only one wiki instance skip the dbname argument [20:32:29] anomie: iirc, we did that to work around the bug, so yeah, if it's been fixed another way I think you can drop it. [20:56:19] I think that ploticus bug happens when we roll a new version [20:56:34] Some kind of cache invalidation? There's usually a spike of them around deploy time then they die off. [21:48:52] Krenair: it only understands --wiki=wiki IIRC [21:49:17] why isn't it compatible with wikimedia's mwscript --wiki? [21:50:15] not sure if that was accidental or intentional; IMO using a proper option=value format is more reasonable [21:50:43] as bd808 says you can omit it altogether if the vagrant instance has a single wiki [21:51:18] although I'm not 100% sure that was intentional either :) [21:52:18] I changed it at some point to not require wiki names when you just run things via 'php scriptname' since usually a vagrant instance is not a wikifarm and it was confusing for non-WMF people [21:56:11] mwscript is very fragile [21:58:46] (or maybe Bryan did the patch and I just whined about it on Phabricator? I am unable to find it now) [21:59:29] lol, I found a "critical" php parser bug in phpstorm :D https://youtrack.jetbrains.com/issue/WI-34134 [22:02:54] https://phabricator.wikimedia.org/T123143 was the related task (or one of them) [22:46:11] anomie: you mean "PasswordPoliciesForUser" ? looks like it could be removed. Was it added in 1.28? [22:46:22] may want to backport it for the older version(s) [22:47:08] AaronSchulz: Looks like it was added in 1.26. I don't know if it was backported.