[14:59:40] 2016/12/13 14:59:14 [error] 32093#32093: *8 FastCGI sent in stderr: "PHP message: PHP Fatal error: Uncaught TypeError: Argument 1 passed to MWExceptionHandler::rollbackMasterChangesAndLog() must be an instance of Exception, instance of Error given, called in /var/www/wiki/includes/exception/MWExceptionHandler.php on line 156 and defined in /var/www/wiki/includes/exception/MWExceptionHandler.php:127 [14:59:57] on 1.25... lol [15:57:39] Reedy: T107933 [15:57:39] T107933: Test on PHP 7.0.0-dev reports PHP Fatal error: on MWExceptionHandler::handleException() - https://phabricator.wikimedia.org/T107933 [15:58:06] Interesting [15:58:14] Seems to be only broken on Wikibase [15:58:59] Upgrading to REL1_28... So should be fixed as a matter of cause [16:00:12] Reedy: TL;DR: PHP 7 added an Error class to "throw" PHP errors, probably so code that catches all exceptions wouldn't start catching PHP errors too. But we get them coming in via the set_exception_handler() callback, I believe, so it started blowing up on the "Exception" type hint. [16:00:43] Can I be bothered backporting to REL1_25 [16:02:29] Nope [16:02:30] :P [16:02:32] Just tell people they have to upgrade to MW 1.26 or later if they want to use PHP 7? [16:03:03] Yeah [16:03:08] It's a wiki I'm upgrading for someone :) [17:04:45] Reedy: I think we said 1.27 is the first release that is guaranteed to work with php 7 [17:04:55] legoktm: yeah [17:05:04] Unfortuantely, the crap due to moving vm, os, php version and mw [17:45:28] Hmm [17:45:38] Anyone know why Module pages have the wrong ContentModel? [17:49:06] /CodeEditor doesn't seem to be working [17:50:43] ContentModel is right [17:53:13] Reedy: WMF or a different wiki? [17:53:16] Different [17:53:36] Not working in what way? Not trying to load? [17:53:53] Yup, it's just showing the default basic toolbar [17:54:08] It's on Special:Version? [17:54:16] Yes :P [17:54:18] if ( $wgScribuntoUseCodeEditor && $title->hasContentModel( CONTENT_MODEL_SCRIBUNTO ) [17:54:20] and that evalutes to true too [17:54:21] what does ?action=info say for content model [17:54:26] oh okay [17:54:30] is WikiEditor being loaded? [17:54:35] oh [17:54:36] nope [17:54:45] legoktm: wtb extension dependancies [17:54:47] * Reedy coughs [17:54:49] CodeEditor is (currently) dependent on WikiEditor. [17:55:03] We're going to fix that soonish. [17:55:31] Also, I have a patch to delete the "default basic toolbar". [17:55:41] I guess I should get that merged. [17:55:47] lol [17:56:19] Reedy, legoktm: You're both already listed as reviewers. :-) [17:56:30] My review queue is large :P [17:56:38] https://gerrit.wikimedia.org/r/#/c/317079/ [17:56:38] WikiEditor is enabled... Still not obviously loading [17:57:32] I'm not sure we should kill it yet. [17:58:50] oh, do I need the preference set too? [18:02:13] Nope [18:04:00] if ( $lang && $output->getUser()->getOption( 'usebetatoolbar' ) ) { [18:04:21] I see [18:04:25] "Enable enhanced editing toolbar" [18:10:19] Yeah, that's why we need to kill the core JS editor. [18:10:45] It's craptastic and yet has a misleading seeming duplicate preference that kills (amongst other things) WikiEditor and CodeEditor. [18:20:04] legoktm: the community wishlist voting reenforced my prior belief that the WMF should have a team that just works on things that you are interested in. :) [18:20:22] global gadgets and global prefs are both going to be in the top 10 [18:47:41] lol [18:47:46] lego team [18:47:49] OMG [18:47:52] OFFSITES TO LEGOLAND [18:49:22] bd808: MAKE IT SO [19:02:00] bd808: heh. [19:02:29] bd808: we discussed global prefs at editing offsite....someone just needs to own the deployment process [19:02:54] legoktm: jfdi [19:02:55] legoktm: cool. I think that CommTech can handle that [19:10:18] Reedy: I'm trying to push out 2-3 other extensions right now :/ [19:22:55] lol [19:24:01] Can I help? [19:34:52] do you want to help with Gadgets 2.0? [19:34:57] I think there are a few open patches that need kicking [19:35:19] anomie: any thoughts about how to split up the TemplateStyles work? [19:35:21] and then cherry-picking stuff from the RL2 branch and making them work with master/modern versions of MW [19:35:59] Reedy: https://gerrit.wikimedia.org/r/#/c/247869/ is the main patch right now... [19:37:24] tgr: Not much yet. I think you'd do a better job of the discussion over {{#tag:}}-supporting and that sort of thing. [19:49:48] anomie: although probably a worse job of understanding what exactly needs to be discussed :) in any case, that's a few weeks off at least. I was thinking of whether rewriting the parser can be split up meaningfully (e.g. into a tokenizer and a parser) or one of us should just have a go at it while the other goes off doing mostly non-TemplateStyles stuff [19:55:19] tgr: I suppose it could be split up, but unless you really want to split it up it sounds like you have plenty of non-TemplateStyles stuff you're already working on. If I do both I'll probably roll the tokenizer and parser into one thing as is mentioned in the first paragraph under https://www.w3.org/TR/css-syntax-3/#tokenization. [19:57:06] ok, let's do that then