[04:24:26] <bd808>	 AaronSchulz: any ideas about an "easy" fix for the wikitech + SMW page lock problem? -- https://phabricator.wikimedia.org/T153618
[04:39:02] <AaronSchulz>	 I can take a look
[04:43:28] <bd808>	 that would be awesome
[17:05:47] <bd808>	 tgr: random oauth idea - I'm seeing quite a few people make grants requests on meta for localhost things. I wonder if we could detect localhost|127.0.0.1 and tell them to do an owner only grant instead?
[17:32:54] <bd808>	 Also it would be nice to have a way to send notes to the grant requestor and leave notes for other approvers.
[17:32:58] <bd808>	 And I would like a pony
[21:45:21] <ostriches>	 Warning: addDeprecation() expects at least 2 parameters, 1 given in /srv/mediawiki/php-1.29.0-wmf.6/includes/api/ApiBase.php on line 1683	1,975
[21:45:21] <ostriches>	 Notice: Undefined variable: feature in /srv/mediawiki/php-1.29.0-wmf.6/includes/api/ApiBase.php on line 1685	1,974
[21:45:25] <ostriches>	 Spammy in wmf.7 ^
[21:46:55] <Reedy>	 Many calls
[21:47:33] <ostriches>	 line 1685: 	}
[21:47:35] <ostriches>	 heh
[21:48:13] <ostriches>	 Oh, wmf.6
[21:48:16] <ostriches>	 Maybe it's going away?
[21:57:08] <ostriches>	 Nope, still on wmf.7
[21:57:10] <ostriches>	 Just less spammy
[21:57:51] <Reedy>	 CodeReview is one possible
[21:57:52] <Reedy>	 				$this->addDeprecation(
[21:57:52] <Reedy>	 					[ 'apiwarn-deprecation-withreplacement', 'ccprop=revision', 'ccprop=status' ]
[21:57:52] <Reedy>	 				);
[21:58:15] <Reedy>	 So is Echo
[21:58:16] <Reedy>	 $this->addDeprecation( 'apiwarn-echo-deprecation-timestampformat' );
[21:58:22] <Reedy>	 Echo 3 times
[21:58:38] <Reedy>	 My code repos locally are a bit out of date
[21:58:41] <ostriches>	 Notice: Undefined variable: feature in /srv/mediawiki/php-1.29.0-wmf.7/includes/api/ApiBase.php on line 1691
[21:59:06] <Reedy>	 presumably that's from the lack of hte parameter being passed?
[22:00:17] <Reedy>	 https://github.com/wikimedia/mediawiki-extensions-CodeReview/blob/1a36fde571f0cef1ef90284958137d83ed5bd107/api/ApiQueryCodeComments.php#L45
[22:00:26] <Reedy>	 https://github.com/wikimedia/mediawiki-extensions-Echo/search?utf8=%E2%9C%93&q=addDeprecation
[22:00:30] <Reedy>	 Yeah, I blame both of them
[22:03:16] <Reedy>	 Patch for CR incoming
[22:04:06] <ostriches>	 You know, not breaking core interfaces without at least checking deployed extensions is kinda lamesauce :(
[22:04:23] <Reedy>	 Wonder who did it?
[22:04:29] <Reedy>	 Brad is usually pretty good at fixing this sort of thing up
[22:04:56] <Reedy>	 Doing Echo no
[22:05:10] <Reedy>	 w
[22:06:52] <Reedy>	 ostriches: https://gerrit.wikimedia.org/r/330736 https://gerrit.wikimedia.org/r/330738
[22:07:19] <Reedy>	 are we cherry picking?
[22:08:10] <anomie>	 Reedy: I bet I thought I made $feature optional when I was doing the extension patches...
[22:08:34] <ostriches>	 Reedy: Ya, I'll do it
[22:08:50] <Reedy>	 anomie: heh
[22:08:58] <Reedy>	 Do we still want to do so in core?
[22:09:21] <anomie>	 Reedy: Nah. I'll just grep to see if there are any other calls where I screwed that up.
[22:09:40] <Reedy>	 I didn't check core
[22:09:51] <Reedy>	 But for extensions, for my slightly out of date clones, it's just CR and Echo
[22:09:57] <Reedy>	 TemplateDate was ok
[22:13:32] <anomie>	 Reedy: Added a comment to https://gerrit.wikimedia.org/r/#/c/330738/1
[22:14:03] <Reedy>	 damn prefixes :)
[22:17:51] * anomie just pulled and recursive-updated mediawiki/extensions, no more instances
[22:20:49] <ostriches>	 CodeReview fix is live
[22:21:57] <ostriches>	 We have 65 counts of an error called ^
[22:22:01] <ostriches>	 And 65 of one called djvu
[22:22:09] <ostriches>	 Er, </mw-djvu>
[22:22:10] <Reedy>	 ostriches: I'm sure I've seen that one before
[22:22:12] <ostriches>	 That sounds fun
[22:23:54] <ostriches>	 Notice: Undefined variable: feature in /srv/mediawiki/php-1.29.0-wmf.7/includes/api/ApiBase.php on line 1691 - We still shouldn't ever be having an undefined variable in ApiBase.
[22:23:59] <ostriches>	 null is one thing, but undefined?
[22:24:49] <ostriches>	 Or is that just weird callback reporting the wrong location of what we're already dealing with?
[22:24:54] <Reedy>	 function foo( $bar, $bar2 ) { echo $bar2; }
[22:24:57] <ostriches>	 That's annoying and unintuitive :p
[22:25:00] <Reedy>	 foo( '' );
[22:25:04] <Reedy>	 surely that'd give undefined?
[22:25:24] <ostriches>	 php is dumb
[22:25:48] <ostriches>	 We should rewrite MW as a scap3 plugin
[22:26:23] <James_F>	 By which time the 'p' will stand for Pascal?
[22:27:38] <ostriches>	 python duhhhhh
[22:37:03] <legoktm>	 import mediawiki
[23:03:35] <bd808>	 from __future__ import mediawiki