[02:57:57] <Krenair>	 "<?xml version=\"1.0\"?><api><login result=\"Aborted\" reason=\"Cannot log in when using MediaWiki\\Session\\BotPasswordSessionProvider sessions\" /></api>" 
[02:59:08] <Krenair>	 looks like this is some strange issue with huggle where a login succeeds but huggle is not happy with the user's config, so cancels, but then when the user tries it again it uses the already logged-in session to log in again
[14:06:24] <anomie>	 Krenair: See also T154324.
[14:06:25] <stashbot>	 T154324: ApiLogin returns failure on re-login by same user - https://phabricator.wikimedia.org/T154324
[22:42:53] <ostriches>	 Blah
[22:42:54] <ostriches>	 Catchable fatal error: Argument 2 passed to WikimediaEventsHooks::onSpecialSearchGoResult() must be an instance of Title, null given in /srv/mediawiki/php-1.29.0-wmf.9/extensions/WikimediaEvents/WikimediaEventsHooks.php on line 448
[22:43:11] <SMalyshev>	 yup search is broken now
[22:43:26] <SMalyshev>	 works if you add fulltext=1 to search query tho
[22:43:33] <SMalyshev>	 not sure why yet :)
[22:46:41] <SMalyshev>	 wait, something is weird. So it says second param is null, which is $title
[22:48:06] <ostriches>	 Saw in group0, is it wider?
[22:49:12] <SMalyshev>	 I can see it on mw.org, did not check others
[22:49:27] <SMalyshev>	 I mean what I can see is blank screen, but I assume that's the reason
[22:55:24] <SMalyshev>	 wmf.9 has broken code there, master is ok though
[22:55:40] <SMalyshev>	 (there being SpecialSearch::goResult)
[22:58:09] <ostriches>	 More hook "fixing" we didn't revert?
[22:59:19] <SMalyshev>	 no actually this seems to be before that
[22:59:27] <SMalyshev>	 the refactored code is ok
[22:59:34] <SMalyshev>	 and wmf.9 doesn't seem to have it
[22:59:52] <SMalyshev>	 7075ea92d2d0cee04ea5e385a24f6c36c2f3f25b has correct code
[23:01:01] <ostriches>	 mw.org is on wmf.9
[23:01:07] <ostriches>	 And I see it in logstash post deploy
[23:01:10] <ostriches>	 :\
[23:01:13] <SMalyshev>	 right
[23:01:20] <SMalyshev>	 so wmf.9 is broken
[23:01:34] <SMalyshev>	 but master (with refactoring & stuff) is not
[23:01:53] <SMalyshev>	 I'm trying to figure out what's up there
[23:03:57] <SMalyshev>	 looks like security patch messed things up - code in git for both master and wmf.9 is ok but one on terbium under php-1.29.0-wmf.9 is not
[23:10:17] <ostriches>	 SMalyshev: Possibly/probably related...
[23:10:18] <ostriches>	 Warning: execute() expects exactly 1 parameter, 0 given in /srv/mediawiki/php-1.29.0-wmf.9/includes/specials/SpecialSearch.php on line 101
[23:10:29] <legoktm>	 see _security
[23:13:04] <SMalyshev>	 hmm second one appears unrelated but the cause might be the same...
[23:19:25] <SMalyshev>	 ostriches: 15:19 <ebernhardson> SMalyshev: that was me in mwrepl
[23:19:38] <SMalyshev>	 :) so yes related ;)