[03:15:20] bd808: https://gerrit.wikimedia.org/r/#/c/333323/ [04:35:23] !bash It doesn't break anything like 90% of the time [04:35:23] bd808: Stored quip at https://tools.wmflabs.org/bash/quip/AVnZDoBiHQCSeVEJfFH1 [04:35:45] Heh [04:36:36] its so true even detached from the original conversation [04:37:25] So true, so true [14:47:45] Krenair: 'hookaborted' errors happen when something makes a hook function fail without setting a real error message. At a glance, for an API edit it could be 'APIEditBeforeSave', 'EditFilterMergedContent', 'EditPage::attemptSave', 'EditFilter'. Maybe more. [14:48:46] yeah [14:48:49] hashar, addshore: I'm curious about mediawiki/libs/phpstorm-stubs, does phpstorm not have that stuff built in? [14:48:56] yup [14:48:59] most probably [14:49:00] I just wasn't sure if we still had any extensions that do that [14:49:04] or at least a way to easily downlopad them [14:49:23] hashar: Seems weird we'd have to reinvent that [14:49:28] the purpose of that fork is to add it as a mediawiki/core require-dev so we can run phan in ci [14:49:56] Krenair: Wouldn't surprise me if there are some still doing that sort of thing [14:50:06] addshore had a bunch of patches to add stubs inside mediawiki/core and eventually we found out reusing some random upstream repo as a composer dev would fit our need [14:50:10] hashar: phan uses phpstorm? [14:50:14] na [14:50:17] it is just the name [14:50:29] that is really just a collection of stub php classes [14:50:42] Ah, so it's phan that doesn't have it built in for some reason... [14:50:44] which are used by phpstorm but can be injected in any php project to provide stubs [14:50:58] that is a good point [14:51:09] guess we can ask phan to ship them automagically [14:51:35] there is an open PR to get jetbrains to publish their stubs to packagist ( https://github.com/JetBrains/phpstorm-stubs/pull/149 ) [14:56:00] different topic [14:56:12] for tgr I have added some basic integration of the REPL psysh https://gerrit.wikimedia.org/r/#/c/334217/ :D [15:10:47] Sigh. Apparently we had a phab upgrade that gratuitously change various classes, so I have to revise my Greasemonkey script that overrides their crappy styling... [15:11:58] yeah been upgraded around 1am UTC [15:54:30] i just stumbled over that upgrade... had to dig around to find out how to create pasteboard entries now.. [19:05:35] anomie: phan will auto-figure out stubs from extensions you have installed, but if you don't have them installed locally, then it can't do anything unless you create stub files. so not having stubs prevented people without all the non-required extensions from running phan basically