[01:38:57] anomie: I'll giva a talk about AuthManager, can I mention you as one of the people who are willing to give advice / code review on auth extension upgrades? [02:08:06] tgr: Ok, although I hope too many people don't take me up on that. [14:52:41] tgr: Something is still funky [14:52:41] Current number of captchas is 242. [14:52:42] Generating 758 new captchas.. Done. [14:52:42] Generated 758 captchas in 121.2 seconds [14:52:42] Copying the new captchas to storage... Done. [14:52:45] Copied 758 captchas to storage in 17.6 seconds [14:52:47] Internal error: captchasGenerated: 1710, successCount: 758, failCount: 0 [14:52:49] Removing temporary files... Done. [14:52:53] 1710!? [14:52:58] Plus internal error... [14:53:23] the internal error just means the numbers don't add up [14:53:48] $captchasGenerated = iterator_count( $iter ); [14:54:24] backport https://gerrit.wikimedia.org/r/#/c/341590/ and all will be good (hopefully) [14:55:09] Hmm. Did that not make it into .15? [18:40:15] tgr|away: [18:40:16] Warning: implode(): Invalid arguments passed in /srv/mediawiki/php-1.29.0-wmf.15/extensions/ConfirmEdit/maintenance/GenerateFancyCaptchas.php on line 197 [18:40:34] That's with your new version [18:41:52] https://phabricator.wikimedia.org/T159607#3088705 for the full output [18:42:06] uhh [18:42:23] yeah, that implode should not be there [18:42:43] since Status->getWikiText returns wikitext [18:42:52] sorry, wrote that in a hurry [18:42:56] it's alright :) [18:42:58] line 219 too [18:43:00] Want me to remove them? [18:43:04] please [18:44:24] https://gerrit.wikimedia.org/r/342067 [18:46:59] tgr: I guess, they should be error calls too, not output [18:47:37] probably [18:47:52] As should a few others [18:47:59] Cause it shouldn't be trying to delete if storing failed for whatever reason [18:49:04] Of course, if we make it die, the script won't clean up temporary files [18:52:44] * Reedy makes a few other tweaks at the same time