[03:59:57] ooh, badges [17:00:21] bd808: https://gerrit.wikimedia.org/r/342650 for your pleasure. :-) [17:05:24] James_F: nice. that shoudl make fixing hashar's patch easier [17:06:35] bd808: James_F: thank you :} [17:10:37] Happy to help. [17:26:52] Helpful [17:26:55] SpecialSearchNogomatch is in hooks.txt [17:26:59] I cannot find it in MW Core [17:27:39] Neither can https://github.com/wikimedia/mediawiki/search?utf8=%E2%9C%93&q=SpecialSearchNogomatch [17:27:43] I'm guessing it's been removed [17:28:17] Which is the best search channel? [17:29:10] I'll go with discovery [17:34:02] Hmm... [17:34:05] Did I kill that hook? [17:34:59] Hmm, no I didn't. [17:35:06] I wonder if it got lost accidentally in a refactor... [17:36:35] Reedy: Found it [17:36:44] https://gerrit.wikimedia.org/r/#/c/320305/ [17:36:46] Yeah, so did I :) [17:36:58] https://gerrit.wikimedia.org/r/342656 fixes releaste notes and hooks.txt [17:37:18] Sorry, I carried on my talking to myself in #wikimedia-discovery [17:39:49] Question of whether I remove it in REL1_28 too... [17:40:11] (and 1.27 and 1.23? This feeks icky) [17:41:00] I think we should revert in master tbh [17:41:04] I -2'd your change saying as much [17:41:36] It's not quite so of a trivial revert now, maybe [17:42:03] goResult has changed a bit [17:42:03] https://github.com/wikimedia/mediawiki/blob/master/includes/specials/SpecialSearch.php#L240-L257 [17:42:22] And showResults call is elsewhere [17:42:36] I *think* we can either just put the hook back in roughly the same place [17:42:46] Or, move it to where we moved showResults to [17:42:50] That's on the original committer to untangle, they're the one who removed a hook with 0 deprecation.... [17:43:13] Mmm [17:46:37] It's in two extensions [17:49:54] https://phabricator.wikimedia.org/T160441 filed [18:01:16] [17:59:38] Reedy: these docs have no bearing on reality, i suppose i have to update them too ("Called when user clicked the "Go" button but the target doesn't exist", but there is no "Go" button and that's not how it's triggered) [18:01:26] [18:00:32] go still occurs, it's just the "default" now instead of having a go button, you press enter or click the magnifying glass in the top right autocomplete [18:49:51] anomie: anything new for SoS? [18:50:46] tgr: Still waiting for code reviews, and feedback on T155813 has been slow in coming. [18:50:47] T155813: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813 [18:52:42] CR is my fault, I'll catch up on it this week [18:52:56] (I'll add it to SoS just in case) [19:01:43] is there a phab tag for all extensions' API? [19:03:21] AFAIK we just use the core tag, and move it on the workboard [20:25:23] anomie: could you give https://gerrit.wikimedia.org/r/342683 & children a look? [21:01:31] tgr: The first one looks good. Gerrit is being really slow for me at the moment. [21:01:56] anomie: thx, the rest does not need to be deployed today anyway [21:03:43] anomie: are you familiar with how make-wmf-branch/config.json works? I'm wondering if it's OK to merge it in the same train cycle as the extension itself or does it block deployment until the next branch split [21:03:58] No idea, sorry [21:05:45] tgr: RainbowSprinkles and Reedy would know [21:06:20] tgr: I think that's fine [21:06:29] It needs to be before the next branch, so it's branched automagically [21:06:29] thx [21:06:38] But if you want the extension there now, you need to manually add the submodule etc [21:08:16] Reedy: what's the "etc" part? branch the extension, add the branch to the mw-core branch as a submodule, do I need to do anything else? [21:08:33] Any and all branches you need it on [21:08:40] Then the usual wmf-config stuff [21:08:57] extension-list, commonsettings/initialisesettings as appropriate, run scap [21:09:19] tgr: Yes, you can merge whenever [21:09:24] (which I'm about to merge now for you) [21:09:51] Whenever zuul catches up to the 21st century [21:56:26] oops, we need to deploy https://gerrit.wikimedia.org/r/#/c/342753/ today :o