[00:23:01] There were 2755 errors: [00:23:31] There were 121 failures: [00:23:51] Tests: 19754, Assertions: 87722, Errors: 2755, Failures: 121, Skipped: 175, Incomplete: 27, Risky: 5. [00:24:03] Good to know my dev wiki is useful for running phpunit [14:08:21] anomie: Any chance I could get you to do a CVE writeup for https://phabricator.wikimedia.org/T68404 please? [14:36:14] Reedy: What does a CVE writeup need to look like? [14:36:37] See https://phabricator.wikimedia.org/T160876 for examples :) [14:36:54] It's mostly I'm not grokking what the issue is with 68404 [14:37:02] I just need the "Flaw" and the "Exploit" part [14:48:38] Reedy: https://phabricator.wikimedia.org/T68404#3150872 [14:49:30] Perfect, thanks [19:23:08] Krinkle: on this page: https://www.mediawiki.org/wiki/Compatibility#Browser_support_matrix we list Opera support as "12.1+". but there never was an Opera 12.1. there was 12.01, and 12.10: https://en.wikipedia.org/wiki/History_of_the_Opera_web_browser#Version_12 . which one is meant here? it comes from your edit: https://www.mediawiki.org/w/index.php?diff=prev&oldid=1079116 [19:38:54] MatmaRex: My guess would be 12.10 [19:38:57] but let me check [19:39:20] MatmaRex: http://caniuse.com/#feat=use-strict [19:39:26] This also uses 11.5 and 12.1 [19:40:35] MatmaRex: What would you like it to be? [19:40:45] * Krinkle runs feature tests in browser stack [19:41:15] oldest I have is 12.12 and 12.14 [19:42:07] Krinkle: caniuse says "Opera 12.1" and "Released Nov 5, 2012", so per https://en.wikipedia.org/wiki/History_of_the_Opera_web_browser#Version_12 it looks like they mean 12.10 [19:42:46] so if that's what you also meant when doing that edit, we should just correct it to 12.10 i guess [19:43:26] (i've only ever tested with the latest 12.x, which is 12.18 right now) [19:43:33] MatmaRex: Do you have.. [19:43:34] Right [19:44:23] they have all the old versions for download at ftp://ftp.opera.com/pub/opera/win/ if you want to try them out very much ;) [19:46:10] https://web.archive.org/web/20121109045046/http://my.opera.com/desktopteam/blog/2012/11/05/12-10-final-released [19:46:27] 12.10 brought SPDY, Fullscreen, Flexbox, prefetch [19:47:44] MatmaRex: http://codepen.io/Krinkle/full/BWbpOz/ [19:48:29] s/win/mac/ [19:49:29] Opera 12.00 for Mac (build 1467) passes all feature tests [19:50:15] Opera/9.80 (Macintosh; Intel Mac OS X 10.11.6; U; en) Presto/2.10.289 Version/12.00 [19:50:32] But that could be considered Grade X if we want to support 12.10 only [19:50:45] MatmaRex: I'll change it to 12.10 for now [19:51:24] 12.00 is still covered by Grade C in terms of it being 10+ [19:51:45] which means if we receive report of a breakage we'll most likely blacklist it to enforce Grade C instead of X [19:51:51] but until then we give it a chance [19:51:59] MatmaRex: sounds good? [19:52:24] Krinkle: yeah [21:14:25] anomie: Thoughts on https://gerrit.wikimedia.org/r/#/q/Id87478964b3985ed8bf4dd00bbc09f65ddfcc130 ? [21:14:31] Should they be backported? Is it needed? [21:14:50] Bawolff and I were a bit confused about "No tests are added here because the only case where it actually makes a [21:14:50] difference is a can-never-happen branch" [21:16:22] Reedy: Personally, I wouldn't bother backporting. The unfixed code is correct for PHP7 and HHVM, PHP5 doesn't complain in the 'success' case, and the 'failure' case should never happen. [21:16:51] Thanks. I'll close the task and abandon the patches