[18:20:08] Now .19 is branched... does anyone fancy merging some of my vendor bumps? https://gerrit.wikimedia.org/r/#/c/339046/ and https://gerrit.wikimedia.org/r/#/c/339044/ are the first ones [18:38:44] doned [18:39:41] MaxSem: Thanks. Needs the patches to the vendor repo too though :) https://gerrit.wikimedia.org/r/#/c/339044/ [18:41:11] <3 [18:41:21] not sure of the last one [18:41:30] no bug, no link to review [18:41:32] the getid one? [18:41:47] oh, the shell one [18:41:50] No, neither am I tbh [18:42:03] Feature that's been added to core... Need to decide if it's useful having on WMF servers [18:42:24] I should probably open a task for this [18:42:53] lol, just noticed my laptop has 0% battery [18:43:46] wait for it to become negative [18:55:57] Reedy: it's definitely useful [18:56:11] might want to ask Security's opnion though [18:56:28] I filed https://phabricator.wikimedia.org/T162181 for it [18:56:37] At least, generically [18:57:04] Needs some massaging to work on our php versions it seems, looks like potentially php 5.6 features or something in some of the symfony [18:59:09] in the tests only [18:59:24] (didn't you file a bug about that some weeks ago?) [18:59:30] yeah [18:59:32] they were lolno [18:59:49] we just need to exempt tests from linting [18:59:56] yeah, should be a bit easier now [19:00:14] would be nice if it was done via composer test but doesn't seem to be the case [19:04:08] should we just exlcude */test/* [19:17:26] is there a word we use to name the page title without namespace part? [19:17:56] unprefixed? [19:18:35] $unprefixedTitle is long... [19:18:41] but maybe it's ok [19:18:52] Title::getPrefixedText() is namespace:title, Title::getText() is just the title part [19:18:53] I was hoping for a specific term maybe [19:18:56] oh [19:19:02] "main part" [19:19:12] ok, that works, thanks [19:19:14] Title::getText() is documented as @return string Main part of the title [19:19:34] ah, excellent, thanks [19:19:41] but if it has underscores it's called the "dbkey" [19:43:56] Yay [19:44:03] Just 4 outdated library [19:47:11] lightncandy is an issue to upgrade isn't it? IIRC [19:48:59] it could be [19:49:11] there are a few extensions that use it directly iirc [19:52:19] I wasn't meaning as a blind upgrade [19:52:32] IIRC there's a reason we're still using the old version [19:53:39] oh, not sure [19:54:32] * Reedy creates a vendor commit to play with [20:56:21] anomie: I think I will merge your CSS library patchset [20:56:54] TimStarling: Ok, thanks! [20:57:23] I'm sure there's more work to be done on it, but I don't see the point in squashing the entire history of a project into a single commit [21:01:37] the security model only depends on the serializer and the whitelist [21:02:55] as long as the serializer is correct, you won't be able to fabricate disallowed rules