[19:42:36] Should we merge parts of https://phabricator.wikimedia.org/diffusion/EUMW/browse/master/SpecialUpdateMediaWiki.php into mediawiki core so mediawiki finally gets an updater. Though we should prevent downloading straight from the gui for now. Instead either providing the download link or mediawiki link. Also we should create a mediawiki page that has alpha, stable, lts release with min php and min mysql versions. [19:44:54] We already have a web updater [19:45:10] RainbowSprinkles i was meaning updating the wiki [19:45:17] ie 1.28 -> 1.29 [19:45:33] Well, there's some long standing disagreement over whether having the web server be able to update its own files is a good idea :) [19:45:51] And if you're still doing the file update by hand, what does that special page give you that mw-config/index.php doesn't? [19:46:37] Oh yep, Reedy was telling me that in -offtopic. But a workaround we could do is not download anything. But notify them theres an update. And give them the mediawiki or download link. [19:46:49] RainbowSprinkles gives you update notifications :) [19:46:56] A special page to notify on new versions is a legit idea [19:47:04] But this file is a mess and does way more than that [19:47:05] :) [19:47:33] We've talked about writing something like a Special:SystemInfo or some such that gives admins the ability to see if they need to update. [19:47:52] Oh that is a nice special page :) [19:47:54] Sorta like special version, but that page suffers from information overload as it is [19:47:58] Yep [19:48:29] with the file above it does something like [19:48:31] $getVersion = json_decode( file_get_contents( 'https://www.mediawiki.org/w/api.php?action=parse&format=json&text=%7B%7B%23invoke%3AVersion%7Cget%7Cstable%7Cversion%7D%7D&prop=text&disablelimitreport=1&disableeditsection=1&preview=1&disabletoc=1&contentmodel=wikitext' ), true ) or die ( 'ERROR' ); [19:48:44] which that parses as 1.28.1. [19:49:08] There's probably a nicer way to do that :) [19:49:12] oh [19:49:42] Heh, it's just passing raw lua to the parser [19:49:46] We could expose a real endpoint [19:50:05] oh [19:50:08] Er, raw wikitext to invoke a lua modle, rather [19:50:33] what about parsing a wikipage? [19:50:36] That or die() is cute [19:50:48] Why would we want to parse anything? We should just expose an actual API for this :) [19:51:05] Probably could get it from Wikidata actually [19:51:20] (which tbh, the lua module could use so we have to update less stuff) [19:51:39] Oh :) [19:56:28] RainbowSprinkles maybe we can create Special:SystemInfo with php and mysql version (yes deplicating Special:Version, but it will be built onto with the mediawiki updater :)) [19:58:28] Maybe. [20:05:08] ok :) [20:18:31] Reedy RainbowSprinkles https://gerrit.wikimedia.org/r/#/c/347060/ :) [20:19:46] I don't have the time to work on something like that right now. And right now it's got a ton of errors: special page not registered, autoloader not registered, reusing messages [20:20:06] oh [20:20:32] And there's no point in copying public static functions, just call the ones from Special:Version [20:21:13] ok [20:23:18] thanks [20:23:19] DOne [20:23:20] :) [22:28:27] RainbowSprinkles: Reedy: https://phabricator.wikimedia.org/T55744#3165270 - is DELETE really that slow? Or do you think something else may be going on? [22:30:34] I can't see why it would be [22:30:46] truncate would be faster in most cases IIRC [22:31:16] ofc, "big wiki" and "using object cache" shouldn't ever go together [22:31:54] It's hard to know if it ends up waiting for locks etc as it's doing the delete [22:42:36] truncate isn't standard is it? [22:43:23] Er, looks like it is, but semantics may be different [22:44:21] Who needs standards anyway [22:44:29] When we can implement things that don't match the standard [22:44:32] Or invent our own [22:45:22] I mean yeah, $db->truncate() is easy enough [22:45:41] In which case, a DELETE with no WHERE could easily be transformed [23:59:44] RainbowSprinkles: From the little info that is in the comment looks like RDMBS may not be the only issue, but also db user rights? [23:59:48] Or am I reading that wrong