[03:15:28] <TimStarling>	 I'm trying to split read-only mode out to its own service, as suggested in a fixme comment
[03:15:49] <TimStarling>	 it is unexpectedly complicated
[03:17:26] <TimStarling>	 there is a circular dependency: wfReadOnly() depends on LoadBalancer, but LoadBalancer construction needs wfReadOnly()
[03:18:06] <TimStarling>	 circumvented in practice but in a way which is awkward for DI
[05:07:16] <TimStarling>	 how are you meant to test ServiceWiring.php?
[05:19:39] <legoktm>	 see MediaWikiServicesTest::provideGetService() which is supposed to instantiate every service in the wiring file
[05:22:16] <legoktm>	 or did you mean more comprehensive tests?
[05:34:10] <TimStarling>	 I'll upload WIP so you can see the solution I came up with
[05:37:34] <TimStarling>	 https://gerrit.wikimedia.org/r/#/c/347315/
[22:50:34] <TimStarling>	 legoktm: did you see that ReadOnlyMode patch? https://gerrit.wikimedia.org/r/#/c/347315/
[22:54:31] <TimStarling>	 I guess another option would be to just keep the GlobalFunctions test
[22:54:45] <TimStarling>	 probably wise in any case