[00:05:07] /25/50 [19:02:05] anomie: why does ApiValidatePassword/ApiLogin not require write-mode but ApiOptions does? Not quite clear on that. It seems like isWriteMode() hails from $wgEnableWriteAPI, which is focused on content and not accounts...but that doesn't explain ApiOptions. [19:02:38] Surely apilogin does write stuff? [19:04:33] AaronSchulz: If login had isWriteMode(), then you'd need the writeapi right to be able to log in. [19:05:01] that part I get [19:05:39] I don't know if there's any strict definition of what exactly "write mode" is supposed to be though. [19:07:22] anything that changes anything in the db iirc? [19:07:25] I see setting isWriteMode() means the 'maxage' parameter is ignored, and it checks $wgEnableWriteAPI and the writeapi right, and a few things you added for the multi-DC stuff. [19:08:38] Reedy: "changes the db" is a little tricky if you have caches or the like in the DB. [19:08:53] doesn't login change user_touched or similar? [19:10:28] Login could theoretically do all sorts of stuff in the DB. Don't we have an extension now that records IP addresses you log in from? [19:10:50] Yuck. https://phabricator.wikimedia.org/P5259 [19:19:29] I was thinking about adding a doesWrites() as special pages have, which defaults to isWriteMode() but only cares about *any* DB pre-send writes. That would let me avoid some logstash spam by overriding for login/logout/validatepassword. [19:22:25] RainbowSprinkles: https://gerrit.wikimedia.org/r/#/c/334337/ might interest you. [19:25:56] hmmmm [20:03:29] Krinkle: i get an interesting new warning in the console: "The resource http://localhost:3080/w/images/thumb/3/31/Red.png/120px-Red.png was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it wasn't preloaded for nothing." [20:03:34] Krinkle: that URL is my wiki's logo [20:03:49] Krinkle: the actual logo is loaded from http://localhost:3080/w/images/thumb/3/31/Red.png/120px-Red.png?82c42 apparently (with the ?82c42) [20:04:45] Krinkle: my setting is $wgLogo = "/w/images/thumb/3/31/Red.png/120px-Red.png"; [20:08:55] MatmaRex: Interesting. Please comment on https://phabricator.wikimedia.org/T100999 [20:09:01] I'll fixup in a bit [20:09:14] Looks like the code diverged between SkinModule and OutputPage [20:09:15] Thanks! [20:09:26] Krinkle: looks like OutputPage::transformResourcePath() in called in ResourceLoaderSkinModule when generating the CSS, but not in OutputPage when generating the preload header [20:09:33] i'll put this on the task [20:09:37] yeah [20:09:47] Yep, that's it. [21:01:41] RFC meeting starting now in #wikimedia-office: Canonical data URLs for machine readable page content [22:26:51] anomie: is this supposed to happen? https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2017.04.12/mediawiki?id=AVtkQ98MQlX7YYkfge8r&_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:now-4h,mode:quick,to:now)) [22:28:42] seems like you just want to counterfactually set them to make sure it's valid, but not save anything (setting email/realname in the object for password != email checks and the like I suppose) [22:38:10] * AaronSchulz realizes he doesn't even need a new method