[18:28:29] <anomie>	 RainbowSprinkles: When will RELEASE-NOTES-1.30 get created in master?
[18:28:44] <RainbowSprinkles>	 Today :)
[18:28:50] <RainbowSprinkles>	 I'm working on branching 29 now
[18:29:50] * anomie went to add release notes to a new patch, but the 1.30 file wasn't there yet
[18:30:40] <RainbowSprinkles>	 Branch script running now
[18:31:20] <RainbowSprinkles>	 core, vendor, skins all branched, working on extensions
[18:31:28] <RainbowSprinkles>	 +2'd the master bump
[18:40:49] <RainbowSprinkles>	 anomie: Master is 1.30 now
[18:40:59] <anomie>	 thanks
[18:41:06] <RainbowSprinkles>	 Well, another 30 seconds
[18:41:07] <RainbowSprinkles>	 grrrr
[18:41:52] <RainbowSprinkles>	 Ugh, composer.lock broken in rel1_29
[18:41:54] <RainbowSprinkles>	 Weird
[19:56:32] <brion>	 Woo branch time :)
[20:06:35] <RainbowSprinkles>	 Composer is busted on rel1_29 though, jenkins ain't happy
[20:08:58] <legoktm>	 how is it busted?
[20:09:49] <legoktm>	 19:44:43 oojs/oojs-ui: 0.21.2 installed, 0.21.1 required.
[20:09:49] <legoktm>	 19:44:43 Error: your composer.lock file is not up to date. Run "composer update" to install newer dependencies
[20:10:15] <legoktm>	 https://gerrit.wikimedia.org/r/#/c/350661/ will fix it
[20:10:32] <RainbowSprinkles>	 gotcha
[20:11:37] <legoktm>	 yay to CI catching real problems :)
[20:11:44] <James_F>	 Indeed!
[20:29:09] <legoktm>	 anomie: in E:ORES, where are the ApiHooks::onAPIGetAllowedParams and co getting registered?
[20:30:28] <Reedy>	 heh, they look a bit orphaned
[20:31:52] <legoktm>	 so it's not just me, good
[20:40:29] <anomie>	 legoktm: Hmm, it looks like I7472c9fc91700048999342605979d6446a552efc removed the hooks for some reason.
[20:41:29] <anomie>	 That would probably explain why I didn't see the parameters the other day when I was looking at the API help...
[20:42:02] <legoktm>	 oh :/
[20:43:12] <anomie>	 It looks like T163687 is the task to turn it back on. tgr might know more.
[20:43:12] <stashbot>	 T163687: Re-enable ORES data in action API - https://phabricator.wikimedia.org/T163687
[20:43:24] <legoktm>	 ok
[20:43:38] <legoktm>	 mostly I was trying to look at an example of how to add parameters to core modules and got confused
[20:44:17] <anomie>	 What sort of parameter are you looking at adding?
[20:45:01] <legoktm>	 I wanted to add a siprop=linterstats option to meta=siteinfo
[20:46:24] <anomie>	 As a new prop, you'd probably want to add a new hook in the 'default' switch case in ApiQuerySiteinfo::execute()
[20:46:45] <anomie>	 OTOH, it might be better to just make a new meta module instead of adding more junk to meta=siteinfo.
[20:48:09] * anomie notes that if the whole dependency injection thing is ever completely done, ApiQuerySiteinfo would probably have 50 things being injected
[20:49:29] <legoktm>	 I was looking at APIAfterExecute but really didn't get that far. a new meta module seems way easier
[23:32:26] <TimStarling>	 I spent half an hour yesterday trying to figure out how to get console debug logging in eval.php so that I could debug etcd in deployment-prep, didn't get there
[23:32:41] <TimStarling>	 I think maybe it should just be a separate SPI