[00:09:06] <TimStarling>	 I recently cloned the whole gerrit extensions tree, after a gap of a few years when I never really had to grep through all extensions for things
[00:09:35] <TimStarling>	 in a pinch, I just grepped in deployed extensions on tin
[00:10:28] <TimStarling>	 so probably everyone knows this already, but can I just say, WikiLexicalData, wow
[00:10:32] <TimStarling>	 that is some special code
[00:13:43] <TimStarling>	 global functions, heavy use of global variables
[00:14:12] <TimStarling>	 global functions with unprefixed names, like one called startNewTransaction()
[08:28:17] <Reedy>	 We have some pretty scary extensions
[08:28:20] <Reedy>	 "we"
[17:01:16] <MatmaRex>	 Krinkle: please look at T165040 and T165031 today, new issues with loading gadgets and site modules. i debugged T165040, there's an idea for a patch i want you to look at. i have absolutely no idea what is causing T165031. i marked them both as deployment blockers.
[17:01:17] <stashbot>	 T165040: MediaWiki:Common.css not applied if it uses '@import' rules and user has any style-only gadgets enabled (works when using ?debug=true and when disabling all gadgets) - https://phabricator.wikimedia.org/T165040
[17:01:17] <stashbot>	 T165031: Gadgets that use both scripts and styles, but do not specify type=general, are never loaded (JS file not loaded but CSS file is) - https://phabricator.wikimedia.org/T165031
[17:04:54] <MatmaRex>	 greg-g: fyi ^
[17:08:39] <legoktm>	 MatmaRex: should we revert?
[17:09:25] <MatmaRex>	 legoktm: maybe. unless someone has any idea what is causing 165031
[17:15:30] <legoktm>	 MatmaRex: https://gerrit.wikimedia.org/r/#/c/353333/
[17:16:38] <MatmaRex>	 legoktm: does that actually fix both issues?
[17:16:43] <MatmaRex>	 huh.
[17:17:01] <legoktm>	 I'm just going on a hunch it'll fix the second one
[17:17:09] <legoktm>	 Were there any other gadgets or RL changes?
[17:18:12] <MatmaRex>	 doesn't look like it
[17:19:40] <MatmaRex>	 (i gotta run for a bit)
[17:26:07] <anomie>	 Reverting that commit does seem to fix the problem locally.
[17:38:04] <anomie>	 It looks like OutputPage "exempts" everything in the 'site' group, then loads just the styles for them in OutputPage::buildExemptModules().
[18:12:30] <anomie>	 greg-g: Hmm. It looks like no one ever reverted https://gerrit.wikimedia.org/r/#/c/350634/ for the MobileFrontend issue. OTOH, maybe since T164733 is already resolved we should just backport https://gerrit.wikimedia.org/r/#/c/352737/ now.
[18:12:30] <stashbot>	 T164733: Section collapsing is broken in MobileFrontend - https://phabricator.wikimedia.org/T164733
[18:12:57] <anomie>	 ("reverted" meaning in 1.30.0-wmf.1)
[18:13:33] <greg-g>	 heh
[18:13:38] <greg-g>	 yeah, might as well fix for real
[18:38:49] <Krinkle>	 Nice bug https://bugs.php.net/bug.php?id=74408
[18:39:17] <Krinkle>	 legoktm:Failure explained on task but nonetheless went ahead with revert. Will need some further thinking
[23:31:38] <Krinkle>	 Wee, brand new Kibana interface?
[23:57:16] <James_F>	 Krinkle: Yeah, upgraded yesterday or the day before?