[06:25:30] Monday. [12:21:50] [13:20:35] Im on LTS, it will take years until that is resolved [12:21:53] more reasons LTS sucks [14:31:24] anomie: can I trouble you to take a look at this re: code de-dupplication https://gerrit.wikimedia.org/r/#/c/351535/ no rush [14:32:15] arlolra: Sure, I'll look once I finish the code review I'm currently in the middle of [14:32:33] great, thanks. it's not urgent [15:05:01] arlolra: Reviewed. [15:05:18] It is quite a bit of code duplication. [15:05:41] * anomie should probably look at that whole extension one of these days to see how much code duplication there is there [15:10:30] much obliged [19:15:06] anomie: in case you haven't seen it: https://lists.wikimedia.org/pipermail/wikimedia-l/2017-May/087524.html :D [19:15:31] legoktm: I did see that, it made me happy too [20:42:56] anomie: hmm, there are multiple styles of @inheritdoc. I've also seen @inheritDoc and {@inheritDoc}. We should probably standardize on one of those [20:45:19] https://www.phpdoc.org/docs/latest/guides/inheritance.html [20:47:56] "As such we are working to include a new (normal) tag in the PHPDoc Standard @inheritDoc that will serve that purpose." [20:47:59] so I'll use that then [21:11:02] James_F: I have a stack of PHPCS patches if you wanna review them https://gerrit.wikimedia.org/r/#/projects/mediawiki/tools/codesniffer,dashboards/default [21:12:58] legoktm: I saw; OK if I review them tomorrow? I'm packing for my flight just now. [21:15:17] sure [21:17:26] I'm waiting for my laundry to finish, I'll poke them [21:19:04] thanks :D [21:26:02] Merged 4 of 5