[11:04:55] https://gerrit.wikimedia.org/r/#/c/354962/ if someone fancies a relatively easy one [16:06:03] Reedy: {{done}} [16:06:12] Thanks! :) [18:33:59] Krinkle: i'm getting "Uncaught TypeError: Cannot read property 'parent' of null" on Commons from the GallerySlideshow gadget, it's doing `mw.util.$content.parent()`. but it has a dependency on mediawiki.util. why is this happening? :o [18:35:41] Krinkle: specifically on https://commons.wikimedia.org/wiki/Special:UploadWizard?debug=1 . this is preventing me from debugging a thing in production, eh. [18:37:20] MatmaRex: In current wmf branch (and as it has been for the past 2 years, but no more since 2 days ago in master), mw.util.$content is set from a $() handler triggered in mediawiki.page.startup [18:37:26] so you must depend on that module also [18:37:35] * Krinkle steps out of his Tardis [18:38:01] MatmaRex: also, safemode=1 :) [18:38:40] oh, right [18:39:08] https://doc.wikimedia.org/mediawiki-core/REL1_29/js/#!/api/mw.util-property-S-content [20:45:56] is anyone available to review https://gerrit.wikimedia.org/r/355642 ? Krinkle? i wanted to swat this. it can't remain broken over the weekend [20:46:24] MatmaRex: I'd support fixing core to re-add some of the removed conditioning for the to at least require a 'href' [20:46:38] It was broadened since the exception for href="#" was no longer needed [20:46:40] Krinkle: i don't want to break it in a different way again [20:46:44] But it was wrong to remove 'href' entirely. [20:46:50] as a requirement [20:46:56] don't navigate by itself [20:47:07] i would like to deploy the UploadWizard workaround, which only affects UploadWizard and which i tested, or revert the bad core change [20:47:16] MatmaRex: It's okay, it won't break anything. It had that requirement orignally until now anyway. [20:48:13] MatmaRex: Interesting, so the
will be target of the click event instead of [20:48:54] yes. it's a silly workaround, but i don't want to change the current design right now, just fix the collapsibles not expanding [20:49:06] (the current design with toggles looking like links) [20:50:32] Uh... [20:50:36] what happened to extensions/ in master [20:50:44] thcipriani: I don't think wmf.2 was meant to be committed to master? [20:51:38] it bypassed gerrit? [20:51:45] Krinkle: what are you seeing? [20:51:52] https://github.com/wikimedia/mediawiki/commits/master/extensions [20:52:03] https://github.com/wikimedia/mediawiki/tree/master/extensions [20:52:08] None of that should exist in master [20:52:13] my local install is acting up because of it [20:52:18] .gitignore being deleted as well [20:52:29] https://github.com/wikimedia/mediawiki/commit/264fc98588a4851324d3e5f2e39ece01e993127e [20:52:31] is the cause [20:57:25] thcipriani: https://gerrit.wikimedia.org/r/#/c/355704/ [20:59:20] that is bizarre. [21:02:40] +2'd. I don't create these branches manually, I use https://github.com/wikimedia/mediawiki-tools-release/blob/master/make-wmf-branch/make-wmf-branch so something must've gone wrong in there somehow. [21:07:45] thcipriani: Aye, no problem. [21:07:55] thcipriani: Do you remember if you had to run it twice for some reason? [21:07:58] Thanks [21:08:04] MatmaRex: patch incominng [21:09:57] I don't remember running it twice, bash history supports this only one: ./make-wmf-branch -n 1.30.0-wmf.2 -o master [21:12:09] Krinkle: thanks. i'll tag it against T166298? hopefully this won't result in any more issues (at least not in anything i maintain ;) ) [21:12:10] T166298: Dropdown options of Upload Wizard are broken (copy metadata, add location and more, non-own-work license options) - https://phabricator.wikimedia.org/T166298 [21:13:14] MatmaRex: ok [21:23:56] Krinkle: i think the comments in your test case were opposite to what is actually happening – can you look at the diff and +1? https://gerrit.wikimedia.org/r/#/c/355715/2..3/tests/qunit/suites/resources/jquery/jquery.makeCollapsible.test.js