[00:01:26] <SMalyshev>	 bd808: I wonder when I have a bunch of methods in StatsdDataFactory that have @inheritDoc but don't actually inherit anything (i.e. parent has no docs and no such method) - did the API change?
[00:01:35] <SMalyshev>	 or am I missing something?
[00:02:37] <SMalyshev>	 ah wait it's in vendor lib... so I don't care
[00:03:26] <bd808>	 :) the upstream looks like someone had an editor macro that put that in by default
[00:03:38] <SMalyshev>	 possible :)
[00:04:19] <wikibugs>	 10MediaWiki-Core-Team, 10MediaWiki-Logging, 07Performance: NullStatsdDataFactory can't be used as StatsdDataFactory service - https://phabricator.wikimedia.org/T166354#3293659 (10Smalyshev)
[00:04:46] <SMalyshev>	 bd808: I filed T166354, not sure which tags to apply to it... can't find a tag for this particular corner
[00:04:48] <stashbot>	 T166354: NullStatsdDataFactory can't be used as StatsdDataFactory service - https://phabricator.wikimedia.org/T166354
[00:06:13] <bd808>	 like so many things "general or unknown"
[00:07:44] <bd808>	 it is kind of interesting that addshore added stuff in 1.27 that isn't working. the buffering class says it was from 1.25
[00:08:02] <bd808>	 maybe usage changed since 1.27 though
[00:08:09] * bd808 is too lazy to blame it all
[00:13:32] <SMalyshev>	 maybe it worked for some settings, e.g. when statsserver is not configured
[00:17:16] <bd808>	 could be
[00:19:43] <anomie>	 TimStarling: Replied to your email
[01:32:11] <addshore>	 So, a bunch of stuff broke for no reason?
[01:46:42] <bd808>	 addshore: I think it was just untested to use your null statsd stuff with some other changes
[01:47:24] <addshore>	 Oooooooh
[01:48:58] <bd808>	 All the icinga noise was something else