[18:47:04] anomie, anything we at commtech can help you with that comment schema change? [18:59:04] MaxSem: btw he's on vacation this week [18:59:19] oh [19:00:07] however, his weekly update said [19:00:20] Core patch for the comment table is up in Gerrit. At the moment tests are failing thanks to Wikibase and the RecentChanges class. [19:00:20] Wikibase's tests construct a RecentChanges object with a fake "row", which generates a warning in the new code about the input row not having the correct fields. [19:00:20] If that warning is removed or bypassed, tests instead fail because it grabs the class's internal storage array and tests it, which breaks because my patch adds a few new properties in there. [19:01:11] and he already made a commit to fix that in WB [19:01:24] https://gerrit.wikimedia.org/r/#/c/363633/ [19:01:28] yep, just found that [22:07:10] harej: see https://phabricator.wikimedia.org/T71445#2995840 [22:08:23] it's a pretty straightforward probem technically but a hard one socially [22:09:20] moving functionality that editors have direct control over to another platform where that control is less direct tends to be controversial [22:10:17] tgr: my idea, short of a more permanent solution to the problem, is to have one gadget that is synced via git, and basically allow anyone who wants to contribute to do so, but have it centralized so that we don't have per-wiki deviations that make bug fixing etc. more frustrating [22:10:47] and by "one gadget" I mean the gadget I am creating to replace FormWizard and AddMe. [22:11:11] centralized gadgets are a mostly solved problem IMO [22:11:36] legoktm and someone (Timo?) were working on an extension just to hold shared gadgets 2 years ago in Mexico City [22:11:47] do it on a central wiki, put bootstrap gadgets on other wikis whoch load the original one [22:12:07] slight performance hit but it's rare that it would actually matter [22:12:41] add l10n for everything, make workflows tweakable per-wiki, ... it gets sticky pretyt fast [22:13:03] software is stupid hard [22:13:20] tgr, I was wondering why more gadgets didn't do that [22:13:23] Just load everything from Meta or something [22:13:23] yeah, there were plans for doing that as an Extension:Gadgets feature (Gadgets 3.0 I think), but it's one of those area's which is no one's job description [22:13:44] harej: lazyness? quite a few do though [22:14:12] FormWizard notably does not, to the point that you have to do a mwgrep to know where it's actually installed. [22:15:21] FormWizard/AddMe as originaly written has hardwired workflows and is not that useful to others [22:16:02] I rewrote AddMe for mw.org but did not port the changes back (yeah, I suck), that version is more flexible [22:16:25] someone making FormWizard more configurable as well would be nice [22:16:46] you do not suck tgr, you just have finite time and energy like the rest of us [22:17:21] Well I'm doing it as a new gadget so that I can be more flexible in my implementation without harming existing uses. [22:17:34] And flexibility is one of the goals. [22:17:57] yeah, I said pretty much the same thing :) [22:18:11] that I'm doing it on mw.org to not break any existing thing [22:18:53] it's not great in the long run, although in the long run a form builder library probably should not live in a gadget anyway [22:20:46] harej: so anyway, if you just want centralization, do it like popups, wiked etc do it and cross-load [22:21:14] I like that idea. Thank you. [22:21:20] the benefit for git is sane review workflow and CI tools [22:21:36] (Can you link to an example of a wiki cross-loading from Meta?) [22:22:10] harej: this easy -- https://wikitech.wikimedia.org/wiki/User:BryanDavis/common.js [22:23:01] so the local gadget would just do something like that plus maybe setup config things for the central code to use [22:23:27] oh sweet, I didn't know mw.loader accepted URLs [22:25:41] not meta specifically, but popups and wiked are loaded from enwiki and hotcat and imageannotator are loaded from commons [22:26:04] you can see examples of localization and local configuration and whatnot in those [22:26:41] hotcat is native to commons? neat, didn't know that [22:26:47] or, if you feel like improving things, you could fix T156210 [22:26:47] T156210: Support translation of JSON blobs in Translate - https://phabricator.wikimedia.org/T156210 [22:27:36] (hm, nevermind, I think that's for gadgets on multilang wikis mainly) [22:28:08] Working predominantly on Meta that's also something I care about :P [22:29:14] I would love if JSON blobs (and Lua modules!) could be localized through Special:Translate. I saw the JSON/Translate markup hybrids that FormWizard uses and I balked. [22:29:16] there is also https://www.mediawiki.org/wiki/Extension:WikEd if you want to see how to turn a gadget into an extension [22:29:45] personally I don't see the point but some people think that's the way to go [22:30:26] I'll consider the extension route once my gadget code is more stable [22:30:37] It adds a lot of procedural overhead for something that doesn't make a lot of difference in practice [22:30:47] Since gadgets are basically treated like trusted code anyway [22:31:38] procedural overhead + testing changes becomes harder [22:32:07] that's the problem with using github as well, absent some form of software integration [22:33:01] For this purpose I consider code review a nice-to-have; knowing centralization on some wiki is an option is perfectly acceptable for now