[00:12:52] <bd808>	 I love the "2008-11-11" date at the top of the readme
[01:09:03] <mwang>	 TimStarling: what timezone are you in?
[01:09:31] <TimStarling>	 UTC+10
[01:09:46] <mwang>	 TimStarling: will you also be there on monday?
[01:11:44] <mwang>	 TimStarling: also, what's the earliest sensible time for a meeting for you, your local time?
[01:11:45] <TimStarling>	 depends on the exact time, but it's OK if you can't find a time that works for me
[01:12:43] <TimStarling>	 7, I guess
[17:19:34] <Reedy>	 No MaxSem when you want him ;)
[17:20:07] <Reedy>	 Anyone familiar with sqlite about?
[17:33:06] <Skizzerz>	 Reedy: I'm not super familiar but I'll be willing to take a stab anyway ;)
[17:33:20] <Reedy>	 It was a relatively simple question...
[17:33:36] <Reedy>	 Does sqlite use mysql's tables.sql verbatim?
[17:33:41] <Reedy>	 Or do we still transform it?
[17:34:09] <Skizzerz>	 give me 3-5 mins and I'll find out
[17:34:33] <Reedy>	 thanks :)
[17:43:10] <Skizzerz>	 Reedy: looks like it is still transformed -- https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/libs/rdbms/database/DatabaseSqlite.php;a10b14d78a4589fbdfe33bc9c9c0a8ab85bd626e$840
[17:43:26] <Reedy>	 cheers
[17:43:34] <Reedy>	 So... Do sqlite updater patches go through that too..
[17:43:46] <Reedy>	 the answer is presumably
[17:43:57] <Reedy>	 as that's a databasesqlite function, not a sqliteupdater..
[17:44:32] <Skizzerz>	 I'd assume so since that's part of replaceVars, which iirc is responsible for expanding the /*_*/ and /*i*/ comments as well, but will verify
[17:44:52] <Reedy>	 please
[17:45:01] <Reedy>	 I can carry on making these numerous table copying patches...
[17:48:51] <Skizzerz>	 Reedy: yes, it looks like those transforms are applied on updates as well; the updater calls $this->db->sourceFile() on every patch, which calls Database::sourceStream which calls Database::replaceVars :)
[17:48:56] <Reedy>	 <3
[17:49:40] <Reedy>	 https://gerrit.wikimedia.org/r/370190
[17:49:43] <Reedy>	 Let's see what this patch does now
[17:50:19] <Skizzerz>	 neat
[17:51:03] <Reedy>	 I guess pgsql and oracle next...
[17:51:25] <Skizzerz>	 I'll do a patch for mssql when that gets merged
[17:51:27] <Skizzerz>	 unless you want to :P
[17:51:43] <Reedy>	 Not particularly
[17:51:59] <Reedy>	 Actually. pgsql and oracle don't *need* to be on this patch really
[17:52:07] <Skizzerz>	 k, I subscribed to the phab task so I'll get an email hopefully when it's good
[17:52:51] <Skizzerz>	 gives me an opportunity to fix a bit more of the schema stupidity going on w/ mssql due to how it stupidly handles key names
[17:53:03] <Reedy>	 oh, buggar
[17:53:10] <Reedy>	 I made silly mistakes on most of them
[17:53:15] <Skizzerz>	 :(
[17:53:19] <Reedy>	 easy to fix
[17:53:27] <Reedy>	 need append _tmp on the new tables being created :D
[17:55:21] <Reedy>	 see what PS6 does
[17:59:58] <Reedy>	 Yay, passes
[18:01:47] <Reedy>	 Hmm
[18:02:03] <Reedy>	 Does SQLite completely ignore (USE|FORCE|IGNORE) INDEX?
[18:02:25] <Reedy>	 because INDEXED BY or NOT INDEXED is the syntax
[18:02:26] <Reedy>	 https://sqlite.org/lang_indexedby.html
[18:03:00] <Reedy>	 If so.. I need to make a couple of modifications to the sqlite patches
[18:03:04] <Reedy>	 As it won't need a second pass like mysql
[18:10:54] <Reedy>	 OuKB: MaxSem!
[18:11:17] <OuKB>	 oh noes!
[18:11:29] <Reedy>	 rofl
[18:11:44] <Reedy>	 wb MaxSem
[18:11:52] <Reedy>	 Don't worry, Skizzerz has been helping me out :)
[18:12:18] <MaxSem>	 seriously though, XChat sucks
[18:12:44] <MaxSem>	 who uses what?
[18:12:45] <Reedy>	 MaxSem: Does SQLite in MW just ignore/remove (USE|FORCE|IGNORE) INDEX from queries?
[18:13:04] <Reedy>	 because we don't seem to transform to INDEXED BY or NOT INDEXED
[18:13:06] <Reedy>	 I use Quassel
[18:14:27] <MaxSem>	 yeah, the syntax is http://sqlite.org/lang_indexedby.html
[18:14:45] <Reedy>	 So MW does completely ignore them?
[18:17:13] <MaxSem>	 ergh, did we kill DatabaseSqliteStnadalone, really?
[18:17:24] <Reedy>	 wut?
[18:19:59] <MaxSem>	 vagrant@mediawiki-vagrant:~$ mwscript eval.php
[18:19:59] <MaxSem>	 > $db=Database::factory('Sqlite', ['dbFilePath'=>':memory:']);
[18:19:59] <MaxSem>	 > $db->select('foo', '*', '1=1', '...', ['USE INDEX' => 'foof']);
[18:19:59] <MaxSem>	 Caught exception Wikimedia\Rdbms\DBQueryError: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading?
[18:19:59] <MaxSem>	 Query: SELECT  *  FROM foo    WHERE 1=1
[18:20:27] <Reedy>	 Perfect