[00:02:45] according to which it uses ketama, which is consistent [04:51:59] TimStarling: https://gerrit.wikimedia.org/r/#/q/status:open+topic:empty-compat [04:52:19] excellent, thanks [04:54:52] there are three more left, and I know MaxSem is already working on one of them [15:14:49] Does anyone have some time to poke at a Special:Contact bug? -- T173839 [15:14:49] T173839: Fix trademark permission request form - https://phabricator.wikimedia.org/T173839 [15:40:49] bd808: Almost certainly oojs-ification related [15:40:50] ala https://github.com/wikimedia/mediawiki-extensions-ContactPage/commit/72532a3ea66c3ea1c7edb543d94fdb192911acf4 [15:41:06] Reedy: that was kind of my thought too [15:44:00] bd808: https://github.com/search?utf8=%E2%9C%93&q=wpProposedUse+%40wikimedia&type=Code doesn't fill me with confidence. [15:44:28] https://noc.wikimedia.org/conf/highlight.php?file=MetaContactPages.php [15:44:38] the wp is appended in code IIRC [15:44:57] https://github.com/wikimedia/mediawiki-extensions-ContactPage/blob/bfb1c40ca8e5e08949d0c6c95fff8f446e26af95/ContactPage_body.php#L346 [15:45:23] … of course. Because why append "mw" or "wmf" when we can append the wrong thing. [15:46:03] See also wpTextbox1 [15:46:19] Indeed, but that's got a historical reason. [15:46:32] I'm guessing HTMLForm::getClassFromDescriptor makes the name wp$name [15:46:35] OK, so, if I change the ProposedUse to "other" and fill in the other box it appears to send. [15:47:06] lol [15:47:11] So it's validating the hidden textbox? [15:47:20] Yeah. [15:47:56] So it's a bug with selectorother [15:48:08] Presumably the selectorother HTMLForm entity is too strict, yes. [15:49:37] Yeah [15:49:38] $this->mOptions = [ $msg => 'other' ] + $this->mOptions; [15:49:49] It just applies all options (in this case, required) [15:50:29] https://github.com/wikimedia/mediawiki/blob/master/includes/htmlform/fields/HTMLSelectOrOtherField.php#L19 [15:51:22] Or is an option what I'm thinking it is... [15:51:45] Each option is a row in the select widget drop-down. [15:53:02] It's in JS though, so I guess we need to fix mw.widgets.SelectWithOther.js [15:58:36] Where's that live? [16:00:27] Reedy: https://phabricator.wikimedia.org/source/mediawiki/browse/master/resources/src/mediawiki.widgets/mw.widgets.SelectWithInputWidget.js [16:00:36] github wouldn't find that [16:00:38] * Reedy grumbles [16:41:02] Receiving objects: 100% (677569/677569), 546.17 MiB | 1.61 MiB/s, done. [16:41:05] MW core isn't small [16:41:33] Nope. [16:41:41] (Did you not have a copy?) [16:42:01] I've got at least 3 or 4 [16:42:06] Felt like I needed another one [16:42:19] * James_F grins. [16:42:28] FWIW, `cp` is lots faster. [16:44:03] shared clones are even faster :) [16:53:55] There's a complaint about wikipedia websites giving an SSL error but it seems to only happen on one laptop on a shared wifi network. It's on the Wikipedia Weekly group on FB. Any ideas what could cause that? The OP said they tried different browsers and incognito mode but the problem persists. [16:55:20] hard to say with just that info [16:55:32] any details on the exact ssl error? [16:55:49] old os. old browser... [16:55:51] could be spyware/adware/vpn/proxy on the laptop [16:56:24] or an os that is hitting the new 5% warning on 3DES encryption [16:56:58] https://usercontent.irccloud-cdn.com/file/XoDe02ef/Screen%20Shot%202017-08-22%20at%209.56.37%20AM.png [16:57:04] The screenshots they shared. [16:57:19] FF? [16:57:22] And it's only for Wikimedia websites, nothing else. [16:57:26] FF and Chrome. [16:59:19] https://wikitech.wikimedia.org/wiki/HTTPS/Browser_Recommendations [16:59:36] might be https://wikitech.wikimedia.org/wiki/HTTPS/3DES_Deprecation [17:00:25] although I woudl expect that to show them https://en.wikipedia.org/test-sec-warning [17:01:27] "ERR_SSL_PROTOCOL_ERROR" would happen if the browser couldn't do any supported ciphers [17:02:35] Alright I'll ask them to make sure their browser is up to date. [17:06:24] Reedy, James_F: thanks for looking into that contact form :) [17:06:32] Just need to fix it :P [17:22:47] Reedy: Details.