[06:14:46] http://phpcs-dashboard.wmflabs.org/sniffs/Generic.Files.OneClassPerFile.MultipleFound.html [15:00:29] https://gerrit.wikimedia.org/r/373302 [15:00:45] Trying to get better wording for "A database query error has occurred. Did you forget to run your application's database schema updater after upgrading?" [19:43:31] brion: Do you happen to recall the purpose of QuickTemplate::setRef? E.g. as used in https://github.com/wikimedia/mediawiki/blob/062f81f5bc7097047dadf6f597564533e1538bfe/includes/SkinTemplate.php#L435-L438 [19:43:48] Krinkle: objects in PHP 4 [19:43:59] As far as I can tell, the reference used there cannot be modified by anything else, so it's presumably not for the purposes of keeping in sync with modifications by other code paths [19:44:02] It's an array [19:44:10] then probably thinking we'd save memory :) [19:44:14] which might or might not be true [19:44:19] Ah, okay, got it :) [19:44:29] That makes sense, and for that reason it is no longer needed I suppose. [19:44:30] afaik it's utterly obsolete yeah :) [19:44:37] brion: Cool, good to hear. [19:45:23] brion: I'm trying to get rid of it, in preparation for making skins more data-driven in one-direction (e.g. run all the php code as needed, producing only data, not HTML, and then passing it off to either SkinTemplate in PHP, or a separate service consuming the data over HTTP). In which case by-reference run-time modifying values are not possible. [19:45:32] But I'm glad that's not how it is used as far as we know [19:45:43] Already removed a bunch but these were left over after https://phabricator.wikimedia.org/T140664 [19:46:00] yay