[18:21:21] <legoktm>	 Reedy, Krinkle: do we want to re-namespace all the libraries under Wikimedia? most are currently under their own names like Cdb\ or UtfNormal\
[18:21:53] <Krinkle>	 legoktm: I think so, yes. I thought it wasn't most though. just a few.
[18:22:28] <Krinkle>	 https://www.mediawiki.org/wiki/Category:PHP_libraries
[18:24:03] <legoktm>	 CDB, CLDRPluralRuleParser, HtmlFormatter, IPSet, Utfnormal, WrappedString
[18:24:37] <legoktm>	 and RemexHtml which isn't in that category
[18:24:39] <Krinkle>	 at-ease: MediaWiki\suppressWarnings.  Wikimedia\base_convert: cdb: \Cdb. cldr: \CLDRPluralRuleParser. css-sanitizer: Wikimedia\CSS. ip-set: \IPSet. html-formatter: \ HtmlFormatter. purtle: Wikimedia\Purtle. Wikimedia\ RelPath. Wikimedia\ RunningStat. . Wikimedia\ ScopedCallback. Wikimedia\TestingAccessWrapper. Wikimedia\ WaitConditionLoop
[18:24:45] <Krinkle>	 Wikimedia\ WrappedString
[18:24:50] <Krinkle>	 \ UtfNormal
[18:25:27] <Krinkle>	 7 vs 9
[18:25:28] <Krinkle>	 oh well
[18:25:36] <Krinkle>	 8 vs 8 without RunningStat
[18:25:38] <legoktm>	 all the new libraries use \Wikimedia
[18:25:41] <Krinkle>	 Yeah
[18:26:01] <Krinkle>	 WrappedString isn't Wikimedia\?
[18:26:10] <Krinkle>	 Hm..
[18:26:11] <Krinkle>	 my bad
[19:38:57] <DanielK_WMDE>	 If anyone wants to have a look at the first stepts towards MCR, I just updated my patch after anomie's first review: https://gerrit.wikimedia.org/r/#/c/374077/17
[21:20:07] <Reedy>	 Hmm
[21:20:08] <Reedy>	 <pre lang="php">
[21:20:08] <Reedy>	 root4 => array(
[21:20:14] <Reedy>	 That should have a $ on it, shouldn't it?
[21:21:02] <Reedy>	 https://raw.githubusercontent.com/wikimedia/IPSet/master/README.md
[21:21:52] <Reedy>	 https://github.com/wikimedia/IPSet/blame/master/README.md#L50
[21:24:55] <Reedy>	 No... But that looks weird
[21:25:59] <Reedy>	 root4 is a member variable of the class
[21:30:13] <Reedy>	 Krinkle: legoktm Is it really worth doing this two step for most of these libraries?
[21:37:17] <Krinkle>	 Reedy: You mean the class compat?
[21:37:23] <Reedy>	 yeah
[21:37:32] <Krinkle>	 Well, without that second layer, we can't upgrade any lib that is used outside of mediawiki-core.
[21:38:02] <Krinkle>	 shouldn't*
[21:38:19] <Krinkle>	 We don't need 2 major releases per se though
[21:38:34] <Krinkle>	 for the namespace rename, the version that renames with compat can be minor
[21:38:51] <Krinkle>	 but if we bump the PHP req, that'll be a major, and then another major to remove it in the future
[21:38:52] <Reedy>	 Not so bothered about that. Just being lazy for numerous classes like CDB
[21:39:11] <Krinkle>	 Reedy: Oh, I wouldn't mind keeping it as-is for some of the libs
[21:39:19] <Krinkle>	 Yeah, but if we do rename it, we need 2 steps
[21:39:32] <Krinkle>	 Anything using MediaWIki\ is better renamed though
[21:39:46] <Krinkle>	 anything using its own namespace is fine for now I suppose. No immediate concern there.
[21:40:01] <Krinkle>	 Or we could rename it with compat and leave it like that for the foreesable future.
[21:46:17] <legoktm>	 2 step sounds good to me
[21:46:45] <Reedy>	 why is the at-east one failing
[21:46:50] <Reedy>	 Oh
[21:46:52] <Reedy>	 ffs
[21:46:53] <Reedy>	 Yeah
[21:50:50] <Reedy>	 finally
[21:58:54] <Reedy>	 class WrappedString extensions \Wikimedia\WrappedString {
[21:58:57] <Reedy>	 gj Reedy
[22:01:33] <Krinkle>	 Reedy: Can you add "use Wikimedia\IPSet" to the example for it?
[22:03:01] <Krinkle>	 Hm.. was this already 0% coverage? https://doc.wikimedia.org/cover/RunningStat/Wikimedia/PSquare.php.html
[22:04:50] <Reedy>	 Not sure tbh
[22:06:46] <Krinkle>	 https://github.com/wikimedia/RunningStat/blob/master/tests/RunningStatTest.php
[22:06:57] <Krinkle>	 https://github.com/wikimedia/RunningStat/blob/master/tests/PSquareTest.php
[22:06:58] <Krinkle>	 Nope
[22:07:04] <Krinkle>	 Looks like we missed one :)
[22:07:35] <Reedy>	 heh
[22:08:31] <Reedy>	 https://gerrit.wikimedia.org/r/375928
[22:11:19] <Reedy>	 Missed another one too.. https://github.com/wikimedia/at-ease/blob/master/composer.json#L2
[22:11:38] <Krinkle>	 Indeed. 
[22:11:45] <Krinkle>	 That one is more important to some extent
[22:11:52] <Krinkle>	 The account under which we want to publish them.
[22:12:02] <Krinkle>	 It's not an alias to the namespace though.
[22:12:06] <Krinkle>	 But yeah, we should update that oo
[22:12:07] <Krinkle>	 too
[22:15:05] <Krinkle>	 Reedy: https://github.com/composer/packagist/issues/47 - once published, we should also abandoned the old package name
[22:15:29] <Krinkle>	 I've got the credentials for those two accounts on packagist (I assume you do as well?). Could do it now if you want
[22:15:46] <Reedy>	 I don't think I have any creds for packagist, I think
[22:19:21] <legoktm>	 I have the pw for the "mediawiki" account on packagist
[22:19:27] <Krinkle>	 Reedy: https://gerrit.wikimedia.org/r/#/c/375930/1
[22:19:46] <Krinkle>	 Reedy: Are you doing any releases yet?
[22:19:56] <Reedy>	 Nope
[22:26:29] <Reedy>	 Should probably make a list of other ones to be changed at some point and dump them on a task
[22:29:16] <Reedy>	 another one https://gerrit.wikimedia.org/r/#/c/375931/
[22:29:17] <Reedy>	 :P