[00:15:16] Hmm, getting another Warning: Using deprecated fallback handling for comment rc_comment [Called from CommentStore::getCommentInternal in /srv/mediawiki/php-1.30.0-wmf.17/includes/CommentStore.php at line 200] in /srv/mediawiki/php-1.30.0-wmf.17/includes/debug/MWDebug.php [00:15:25] I thought we'd backported everything [00:17:02] AbuseFilter's fault this time [00:18:39] Special:Filter/examine [00:22:30] https://gerrit.wikimedia.org/r/#/c/376649/ [00:22:56] Same way jdlrobson fixed it for MobileFrontend [00:24:01] MaxSem: ty [03:18:52] seems like not all JS methods make it into the documentation at https://doc.wikimedia.org/mediawiki-core/master/js/ [03:19:00] mw.track for example [14:26:14] no_justification: https://gerrit.wikimedia.org/r/376723 for the getKey() one. Simple typo in the method name. [14:26:42] no_justification: Also, https://gerrit.wikimedia.org/r/#/c/376709/ [14:27:24] heh [15:50:02] anomie: Thx on both, and whoops on the 2nd [15:50:05] Backporting now [17:48:46] legoktm: I saw a phpcs error the other day about files not containing PHP code. But they're symlinks. And not even a symlink to a PHP file. That's....wrong? [17:50:03] Here's the case I'm referring to: https://integration.wikimedia.org/ci/job/operations-mw-config-composer-hhvm-jessie/6210/console - the docroot entries [17:50:14] Yeah, known issue [17:50:24] Which.. I don't think we've filed upstream yet [17:51:17] https://phabricator.wikimedia.org/T171510 [17:53:58] Ah didn't know we had a task already [18:22:03] Reedy, why are you fixing Memento instead of nuking it from the orbit? :P [18:22:10] Can I? [18:22:23] I just noticed it had a git submodule for mediawiki-codensiffer [18:22:23] we can dream at least [18:22:27] And that made me sad [18:22:31] #doingitwrong [18:23:27] some things should just be left anone. let natural death take its course XD [18:25:44] I remember Memento [18:25:47] I do also remember not caring [18:25:48] :p