[19:33:55] <legoktm>	 anyone around? file stuff is pretty broken related to comments, but I need someone to review https://gerrit.wikimedia.org/r/376880
[19:34:53] * legoktm pokes Reedy gently ^
[19:39:27] <Reedy>	 It looks sane
[19:40:36] <Reedy>	 legoktm: I'm also not sure if we should deploy it
[19:40:41] <Reedy>	 Though, I'm thinking jfdi
[19:41:00] <legoktm>	 I think the current situation is pretty broken
[19:41:21] <legoktm>	 file description page for old revisions, plus the API breakage will affect any downstream user of foreignapirepos/instantcommons
[19:43:42] <legoktm>	 Reedy: thanks. are you going to sync it?
[19:46:27] <Reedy>	 Waiting for jerkins
[19:58:38] <legoktm>	 Reedy: I'll sync it out now 
[19:58:50] <Reedy>	 Sorry, GTA V was distracting me
[20:01:33] <legoktm>	 hmm
[20:01:38] <legoktm>	 I synced it out to mwdebug1002
[20:02:08] <legoktm>	 https://commons.wikimedia.org/wiki/File:Example_en.svg#filehistory
[20:02:21] <legoktm>	 viewing on mwdebug1002 I see the bottom two comments, but not the latest one
[20:03:10] <Reedy>	 :/
[20:03:56] <legoktm>	 the API works properly
[20:04:14] <legoktm>	 my local testing worked fine though
[20:04:29] <legoktm>	 I see the comment for the latest and old revisions
[20:04:44] <Reedy>	 legoktm: Purged and it's fixed
[20:05:12] <legoktm>	 o.O
[20:05:18] <legoktm>	 do we need bump a cache key somewhere?
[20:05:37] <no_justification>	 Hmmmm
[20:05:59] <legoktm>	 probably because I changed getCacheFields()
[20:06:02] <Reedy>	 Almost sounds like it
[20:06:53] <legoktm>	 ok, working on patch to make old cache entries work
[20:13:56] <legoktm>	 Reedy: [13:13:36] <wikibugs> (PS1) Legoktm: LocalFile: Fallback to 'img_description' for cached entries [core] - https://gerrit.wikimedia.org/r/376920
[20:14:57] <legoktm>	 er, look at PS2
[20:17:40] <Reedy>	 We should work out what the cache period is..
[20:17:53] <Reedy>	 Though, maybe just cherry pick that to .17 and not merge on master?
[20:19:13] <legoktm>	 		if ( isset( $row->${"{$prefix}description_text" } ) ) {
[20:19:17] <no_justification>	 Or just wait for caches to expire
[20:19:17] <legoktm>	 shouldn't the isset prevent warnings?
[20:19:18] <no_justification>	 nbd
[20:19:19] <no_justification>	 :P
[20:19:23] <legoktm>	  Notice: Undefined variable: img_description_text in /home/km/projects/gerrit/mediawiki/core/includes/filerepo/file/LocalFile.php on line 550
[20:21:49] * legoktm swaps to property_exists()
[20:24:38] <legoktm>	 ok, I cherry-picked it on to mwdebug1002 and it works properly pre-purge and post-purge
[20:25:22] <legoktm>	 I'll just merge it for wmf.17 and let us figure out what to do for master later
[20:42:49] <legoktm>	 deployed everywhere