[20:15:24] <DanielK_WMDE__>	 I have been wondering about this for a looong time. Can someone enlighten me? https://phabricator.wikimedia.org/T175745
[20:19:34] <no_justification>	 DanielK_WMDE__: My *guess* would be "try to avoid an edit conflict response whenever possible"
[20:19:44] <anomie>	 Given how long ago it was, I'd ask brion or TimStarling if they remember.
[20:19:56] <no_justification>	 They're ridiculously annoying to unwind for the average user.
[20:20:38] <DanielK_WMDE__>	 no_justification: just overwriting the previous edit is better? and leave it to the user to notice, and then somehow merge after the fact? that seems a lot worse.
[20:20:44] <brion>	 So
[20:20:51] <no_justification>	 DanielK_WMDE__: I said, guessing :)
[20:20:55] <brion>	 Back in the day if you used the edit form and saved
[20:20:57] <no_justification>	 Yay, uncle brion here for story time :D
[20:21:01] * no_justification settles in
[20:21:02] <DanielK_WMDE__>	 \o/
[20:21:05] <brion>	 And then clicked back and made a further change and save again
[20:21:09] <brion>	 It would edit conflict
[20:21:14] <brion>	 I think this was a hack for that
[20:21:32] <brion>	 But yeah if it fucks you up it's... not pretty
[20:21:59] <DanielK_WMDE__>	 ah... that would work because "back" took you back to a text field that still had the modified text, which you could then adjust?
[20:22:08] <DanielK_WMDE__>	 this was before tabbed browsing, yes?
[20:22:16] <DanielK_WMDE__>	 this seems to be doing more harm then good...
[20:22:22] <brion>	 Yeah Netscape 4 days
[20:22:31] <brion>	 It may be,,. Unwise now.
[20:22:39] <DanielK_WMDE__>	 brion: would you put that on the task, for posterity? or should i just copy what you just said here?
[20:23:11] <brion>	 Copy paste, I'm afk and on crappy iPhone kbd 🙀
[20:23:40] <DanielK_WMDE__>	 the relevant query is nasty and unreliable, i'd love to kill it!
[20:23:52] <DanielK_WMDE__>	 ...instad of porting it to the new RevisionStore
[20:24:32] <brion>	 :)
[20:25:54] <DanielK_WMDE__>	 brion: done, thank you!
[20:26:36] <DanielK_WMDE__>	 brion: i spend like half an hour to find the commit that introduced this. only to find that it was introduced by the *first" commit ever.
[20:27:02] <DanielK_WMDE__>	 fun times ;)
[20:32:32] <TimStarling>	 I'm sure people do still use the back button
[20:33:12] <TimStarling>	 I think I hit this as a feature before I ever heard about it being a bug
[20:33:43] <TimStarling>	 I think we broke it by accident once, and people complained
[20:34:35] <TimStarling>	 of course it could be more specific, you could easily detect separate tabs/windows
[21:12:13] <no_justification>	 Warning: Using deprecated fallback handling for comment rc_comment [Called from CommentStore::getCommentInternal in /srv/mediawiki/php-1.30.0-wmf.17/includes/CommentStore.php at line 200] in /srv/mediawiki/php-1.30.0-wmf.17/includes/debug/MWDebug.php on line 309
[21:12:22] <no_justification>	 Yay, more of those
[23:03:07] <tgr>	 bd808: can't complain about that CR turnaround time :)
[23:03:43] <bd808>	 tgr: :) it was the kind of change that would conflict really fast
[23:04:00] <bd808>	 also its something I've thought about doing a dozen times
[23:06:43] <TimStarling>	 no_justification: CommentStore is logspamming?