[01:35:07] <legoktm>	 bd808: My Firefox is saying that the X-Wikimedia-Debug addon is LEGACY. Does it need to be ported to the new addon system?
[02:13:12] <legoktm>	 I ran the Chrome extension through https://www.extensiontest.com and it says "Great news! Your extension is compatible with Firefox." so maybe we just need to submit that one to AMO?
[02:49:14] <bd808>	 legoktm: yeah, if the chrome version works with the new broken Firefox someone should do that 
[02:49:33] <legoktm>	 ok, I'll play with that tonight or tomorrow then
[02:49:58] <bd808>	 I can give you access to the chrome account too I think if you are interested 
[02:51:58] <legoktm>	 uh, I try to avoid chrome stuff :/
[02:52:10] <bd808>	 Heh. Fair
[02:52:13] <legoktm>	 but I guess we'd be just using one code base for both right?
[02:52:35] <legoktm>	 I'll ask you about permissions once I have something working :p
[02:52:47] <bd808>	 Cool beans
[02:53:27] <bd808>	 I think Timo has rights to upload chrome builds too
[06:11:44] <legoktm>	 bd808: ok, I tested it in Firefox and it all basically just works. 
[06:12:12] <legoktm>	 bd808: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Publishing_your_WebExtension is the guide to follow, is that something you want to do or want me to do?
[08:17:02] <Krinkle>	 bd808: afaik only git repo access, i've never pushed a release nor know how to
[08:17:13] <Krinkle>	 assuming it doesn't auto publish after git tag
[18:01:22] <DanielK_WMDE_>	 CindyCicaleseWMF, anomie, brion: gah! i missed the meeting! Sorry...
[18:38:20] <legoktm>	 Krinkle: I'm glad you enjoyed my little easter egg :) what do you think the path forward for https://gerrit.wikimedia.org/r/#/c/374422/ is ? does it need more testing? or can we just do it?
[19:38:29] <no_justification>	 Krinkle: Thx for the merge on that svg by the way
[19:39:39] <no_justification>	 Notice: Undefined index: id in /srv/mediawiki/php-1.30.0-wmf.18/extensions/OAuth/backend/MWOAuthDAO.php on line 180
[19:39:43] <no_justification>	 anomie: would that be you? ^
[19:40:01] <no_justification>	 Or tgr, maybe
[19:40:07] <anomie>	 no_justification: I'll look at it anyway
[19:40:20] <no_justification>	 Thx, I was thinking auth people :)
[19:41:48] <no_justification>	 [{exception_id}] {exception_url} BadMethodCallException from line 170 of /srv/mediawiki/php-1.30.0-wmf.18/includes/api/ApiFeedWatchlist.php: Call to a member function getApiCode() on a non-object (string)
[19:41:53] <no_justification>	 Derp, that one is you!
[19:41:57] <no_justification>	 I can paste full stacktrace
[19:42:15] <no_justification>	 Eh, simple
[19:42:33] <no_justification>	 https://phabricator.wikimedia.org/P6009
[19:50:03] <no_justification>	 Ew: Notice: iconv(): Detected an illegal character in input string in /srv/mediawiki/php-1.30.0-wmf.18/extensions/CentralAuth/includes/CentralAuthUser.php on line 1991
[19:51:22] <anomie>	 no_justification: https://gerrit.wikimedia.org/r/378089
[19:52:06] <no_justification>	 lgtm, thx
[19:53:47] <anomie>	 no_justification: https://gerrit.wikimedia.org/r/378090
[19:54:06] <no_justification>	 Yay easy fix
[20:09:40] <no_justification>	 anomie: OAuth fix live & confirmed good. Backporting API typofix
[20:17:47] <no_justification>	 anomie: API feed fix live too
[20:26:38] <no_justification>	 Hmm: [{exception_id}] {exception_url} BadMethodCallException from line 146 of /srv/mediawiki/php-1.30.0-wmf.18/includes/api/ApiQuerySearch.php: Call to a member function termMatches() on a non-object (boolean)
[20:28:41] <MaxSem>	 gotsa invite ebernhardson here
[20:29:39] <anomie>	 no_justification: T167410
[20:29:39] <stashbot>	 T167410: ApiQuerySearch.php: Call to a member function termMatches() on a non-object (boolean) - https://phabricator.wikimedia.org/T167410
[20:31:01] <no_justification>	 Got it thx
[20:31:15] <no_justification>	 I'm playing spam irc with log messages today
[20:31:25] <no_justification>	 See how many we can fix 
[20:34:29] <no_justification>	 Also hmm: MediaWiki\Extensions\OAuth\SpecialMWOAuth::execute: Exception oauth_callback must be set, and must be set to "oob" (case-sensitive), or the configured callback must be a prefix of the supplied callback.
[20:34:59] <anomie>	 no_justification: That one is a user error, I believe.
[20:36:01] <no_justification>	 Aren't all? :p
[20:36:54] <anomie>	 The only thing to do to fix it is to stop logging it at https://phabricator.wikimedia.org/diffusion/EOAU/browse/master/frontend/specialpages/SpecialMWOAuth.php;b227052466de2ae77ead4127f3e81045f79ec483$214
[20:38:00] <no_justification>	 Or log it differently
[20:42:17] <no_justification>	 Can I get a sanity check on https://gerrit.wikimedia.org/r/#/c/376762/?
[20:42:24] <no_justification>	 Is there something I'm forgetting here?
[20:44:03] <no_justification>	 As best I can tell, /everything/ else just uses the one in private/
[20:44:34] * anomie has no idea
[20:45:19] <no_justification>	 Imma try.
[20:45:21] <no_justification>	 Hang on
[20:45:32] <no_justification>	 Oh.
[20:45:33] <no_justification>	 Beta
[20:45:34] <no_justification>	 One sec.
[20:45:43] <no_justification>	 I bet beta's symlinks somewhere different
[20:53:52] <no_justification>	 Actually should work