[04:07:20] <bd808>	 legoktm: is my idea at https://phabricator.wikimedia.org/T148783#3652887 to make it optional for MassMessage to send emails instead of talk page pings crazy?
[04:07:39] <bd808>	 I don't want to start on code if it is :)
[04:11:20] * legoktm looks
[04:11:32] <legoktm>	 it's not too crazy
[04:12:10] <legoktm>	 but I don't think it should be possible to send random emails via a web UI, it should be started via CLI script
[04:12:24] <legoktm>	 but you can still use a mass message input list for it
[04:13:06] <legoktm>	 so I think a maint script that gets a list of users from a MM input list and sends them emails would be acceptable
[16:09:41] <anomie>	 bd808: I forgot our meeting.
[16:11:57] <bd808>	 anomie: no worries. I thought about pinging you but I was in the middle of fixing a UBN! bug in Toolforge :)
[16:13:07] <anomie>	 I'm involved in a metaphorical situation with a shaving kit and a yak.
[16:16:16] <bd808>	 heh. this action figure is on my desk -- https://www.amazon.com/Palisades-Ren-Stimpy-Shaven-Action/dp/B000302CQM
[16:19:03] <anomie>	 Heh
[18:13:44] <greg-g>	 anomie: I think you and james are both right just it's not clear which wikis are affected? Or?
[18:15:30] <anomie>	 greg-g: I don't know which of the three bugs might have caused the issue. Although if it's still happening right now, it's probably not either of the closed ones.
[18:18:28] <greg-g>	 gotcha
[18:20:45] <RoanKattouw>	 I think I have found it
[18:21:00] <RoanKattouw>	 https://gerrit.wikimedia.org/r/#/c/382756/
[18:21:10] <RoanKattouw>	 greg-g: anomie addshore James_F ---^^ I think that revert might fix things
[18:21:33] <RoanKattouw>	 The behavior that commit adds is shady anyway IMO and I've proposed a revert in master as well
[18:21:57] <greg-g>	 oh good, you were calling your own code shady
[18:21:58] <RoanKattouw>	 But I think the stack traces on T177524 are pretty convincing that this patch is contributing to the problem, so I propose we revert it
[18:21:58] <stashbot>	 T177524: "User::loadFromSession called before the end of Setup.php" due to a combination of TwoColConflict and BetaFeatures - https://phabricator.wikimedia.org/T177524
[18:22:07] <greg-g>	 +1
[18:22:07] <RoanKattouw>	 greg-g: No I was calling addshore's code shady
[18:22:16] <greg-g>	 oh right, mis-quick-read
[18:22:18] <RoanKattouw>	 My code is affected by this because it uses the preference system :P
[18:22:22] <RoanKattouw>	 which is not a high bar
[18:23:06] <greg-g>	 do the needful
[18:23:40] <addshore>	 RoanKattouw: that breaks the preference system?
[18:23:45] <addshore>	 *checks*
[18:24:04] <RoanKattouw>	 As far as we can tell
[18:24:20] <RoanKattouw>	 See T177524, people are reporting being unable to change their prefs on certain wikis
[18:24:28] <RoanKattouw>	 In any case, what TwoColConflict is doing here is causing errors
[18:25:00] <addshore>	 Okay, yep, revert and I'll look into it next week. Vey confused though
[18:25:00] <RoanKattouw>	 It's not a slam dunk that those errors are definitely related to the prefs problem, but they're auth system errors so it's not a stretch, and errors are bad anyway
[18:25:16] <RoanKattouw>	 OK, I'll revert and then explain what I believe the problem is
[18:25:47] <addshore>	 That's exactly what the check at the start of that method is for, but it's believable that something else is up
[18:26:36] <RoanKattouw>	 It sounds like there are two code paths that cause the badness and only one of them is caught by that check
[18:26:53] <addshore>	 RoanKattouw: ack!
[18:27:24] <addshore>	 I'm only on a phone now, but could you assign me to the ticket about this so that I can investigate before next week's branch?
[18:28:12] <RoanKattouw>	 Will do
[18:28:27] <greg-g>	 I just made that task a blocker to next week's train for added visibility
[18:28:32] <RoanKattouw>	 The gist of my understanding is as follows:
[18:29:03] <addshore>	 Thanks greg-g 
[18:29:04] <RoanKattouw>	 1) During user autocreation (right before the user is actually created), AbuseFilter is asked to check if the proposed username is kosher
[18:29:23] <RoanKattouw>	 2) AbuseFilter in the course of its normal business calls SpecialPage::getTitleFor( 'something' )
[18:29:32] <RoanKattouw>	 3) This calls the hook to gather special page definitions from extensions
[18:29:46] <RoanKattouw>	 4) TwoColConflict hooks into this, and tries to register its special page, but first checks if the user has the BF enabled
[18:30:07] <RoanKattouw>	 5) This calls $user->getOption() on a User object that's in the middle of trying to be created
[18:30:29] <RoanKattouw>	 6) ??? Bad things happen, I'm very fuzzy on how things get screwed up from here on out, but #5 sounds bad
[18:31:03] <addshore>	 Thanks for the write up! Sorry for breaking shit :)
[18:31:18] <RoanKattouw>	 No worries
[18:31:26] <RoanKattouw>	 It wasn't exactly clear
[18:31:33] <RoanKattouw>	 And I'm still not sure that this is what causes the problem
[18:31:52] <RoanKattouw>	 So before deploying this revert (it just merged), I'm going to try to reproduce it myself first
[18:32:05] <anomie>	 RoanKattouw: It looks like there's another code path via ShortUrl that doesn't involve autocration.
[18:32:24] <RoanKattouw>	 OK definitely broken for me now (without the revert) when I try to change my user lang on hiwiki
[18:32:30] <RoanKattouw>	 Let's try with
[18:36:27] <paladox>	 Hi, i am wondering could someone point me to where contribs section for the user is added
[18:36:28] <paladox>	 ie in check user it shows
[18:36:30] <paladox>	 https://phab.wmfusercontent.org/file/data/eyuyotclexmoli6dub7e/PHID-FILE-ypzj7tp24pxsxemzy6ck/Screen_Shot_2017-10-06_at_19.26.58.png
[18:36:50] <paladox>	 though i am trying to help pin point to some one how to make it go to red. But found it has no class.
[18:36:54] <paladox>	 so one needs to be added.
[18:37:13] <paladox>	 https://phabricator.wikimedia.org/T170507
[18:37:42] <RoanKattouw>	 Yup this fixes it
[18:38:01] <anomie>	 RoanKattouw: Random idea, if you feel like digging into it more: It may be that adding a call to $this->clearInstanceCache() at the top of User->loadFromSession() would help with the breakage (i.e. it might be still be caching the anon's options on the non-anon User object after finally loading it from session).
[18:38:02] <addshore>	 Coolio!
[18:38:27] <addshore>	 Right, I'm off for the night
[18:38:35] <RoanKattouw>	 OK, have a good weekend
[18:39:16] <RoanKattouw>	 anomie: So, strangely, I tried changing my prefs on hiwiki and it didn't stick, but then when I switched to 1002 it did have the pref change without me changing it again
[18:39:25] <RoanKattouw>	 OK that patch is deployed now
[18:39:57] <RoanKattouw>	 And opting out of the new RC works for me
[19:28:12] <paladox>	 never mind
[19:28:18] <paladox>	 we found duplicate code
[19:59:16] <bd808>	 RoanKattouw: how did this username pass the kosher test? -- https://meta.wikimedia.org/w/index.php?title=Special%3ACentralAuth&target=YHWH -- ;)
[20:04:34] <RoanKattouw>	 lol
[20:04:45] <RoanKattouw>	 First edit of that user was on https://fr.wikipedia.org/wiki/Portail:Anarchisme/citation
[20:06:24] <paladox>	 hmm i get this
[20:06:24] <paladox>	 Warning: Using deprecated fallback handling for comment rc_comment [Called from CommentStore::getCommentInternal in 
[20:06:27] <paladox>	 in the tests
[20:06:32] <paladox>	 https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm-jessie/24468/console
[20:06:36] <paladox>	 20:06:02 Warning: Using deprecated fallback handling for comment rc_comment [Called from CommentStore::getCommentInternal in /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/includes/CommentStore.php at line 212] in /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/includes/debug/MWDebug.php on line 309
[20:06:36] <paladox>	 20:06:04 PHPUnit 4.8.35 by Sebastian Bergmann and contributors.
[20:12:51] <paladox>	 why does this https://github.com/wikimedia/mediawiki/blob/afbf5e7899a44981eeb5accdfc895effce7be9f3/includes/Linker.php#L897 === false?
[20:12:55] <paladox>	 it could be ! :)
[20:25:25] <paladox>	 hi, i am wondering could someone review this https://gerrit.wikimedia.org/r/#/c/382780/ core change please.
[20:25:28] <paladox>	 ?'