[00:42:23] anomie: could you take another look at https://gerrit.wikimedia.org/r/#/c/379724/ ? your last set of comments should be fully addressed now [15:58:18] Krinkle: I don't really have any feedback to give. The first two checkmarks are already checked, #3 isn't something I know anything about, and #4 and #5 seem like straightforward tech debt cleanup in making callers use the stuff added in #1 and #2 wherever possible. [17:51:23] legoktm hi, im wondering could you review https://gerrit.wikimedia.org/r/#/c/193434/ today please? :) :) [17:52:05] oh yeah, I owe you that. let me do that now [17:52:25] ah thanks, and oh you doint own me anything heh :). [18:55:27] yayay thankyou legoktm [18:55:30] :) [19:06:25] i guess we can now move all of wmf to use svg with png fallback. Better quality logo :). [19:09:49] yep! [19:10:41] paladox: we could add 'svg' then wait for whatever caches we need to expire, and then remove the 1.5x/2x ones [19:11:03] yeh, though doint we need to support old browser? [19:11:11] ah i see [19:11:52] isn't the png fallback for the older browsers? [19:11:57] yeh [19:12:07] svg will overide png :) [19:12:59] i will create a task, since there is a high density one, but that's not needed now that we have svg :). [19:15:33] legoktm i've created https://phabricator.wikimedia.org/T178942 : [19:15:34] :) [20:23:35] no_justification, hasharAway: https://gerrit.wikimedia.org/r/#/c/386263/ and https://gerrit.wikimedia.org/r/#/c/386260/ [20:23:59] * legoktm runs away to class [20:24:49] +2 on both. Do those need to land in wmf.5? [20:25:05] legoktm: you are awesome [20:25:19] no_justification: that is for a change that got merged in master like 3 hours ago [20:25:25] so I dont think there is any need for a backport [20:25:46] Ok, just wondering :) [20:26:12] legoktm is just plain awesome :] [20:26:18] paladox: bugs got fixed! [20:26:24] thanks :) [20:26:46] whenever that is merged by CI and updated on beta, the job https://integration.wikimedia.org/ci/job/beta-scap-eqiad/ should work again [20:26:54] unless there is another issue [20:28:45] ci is currently down [20:28:50] hasharAway ^^ [20:29:15] how? [20:29:57] hasharAway we think do to a change to lock down gerrit to an ip [20:30:03] but dzahn is revert it partially [20:30:09] to open it to * again. [20:30:17] lets follow in #wikimedia-operations [20:31:03] ok [20:34:11] That's a second issue [20:35:38] I have CR+2 both patches above [20:52:53] anomie: is there a "how to debug session/login issues" tutorial somewhere on-wiki? [20:53:11] tgr: Not that I know of. [22:25:36] legoktm: https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm-composer-jessie-non-voting/749/console [22:26:42] yeah, people can do that in their LocalSettings.php [22:26:51] or in a callback as I suggested in the commit message [23:22:05] there is now: https://www.mediawiki.org/wiki/Manual:How_to_debug/Login_problems