[01:15:14] <legoktm>	 Krinkle: speaking of coverage, https://gerrit.wikimedia.org/r/#/c/386565/
[16:33:44] <Krinkle>	 SMalyshev: It depends. Strictly speaking, a unit test class would have one or more test*() methods for each of the class' methods and cover only that one. The main point of declaring @covers explicitly (which is an option we choose to enable for MW) is to not consider indirect coverage.
[16:34:33] <Krinkle>	 But if a class is largely composed of static or protected/private methods with only a handful of similar public methods, it might not make sense to test each of the intenral utitlies separately. If anyhthing, covering the class a whole could help identify dead code as well.
[17:24:23] <Krinkle>	 legoktm: Filed https://phabricator.wikimedia.org/T179094
[17:34:39] <no_justification>	 bd808: Mind a quick look at https://gerrit.wikimedia.org/r/#/c/386661/?
[19:27:45] <no_justification>	 bd808: Another one, but I'm less sure if I'm doing it right: https://gerrit.wikimedia.org/r/386689
[20:16:37] <no_justification>	 Catchable fatal error: Argument 1 passed to EditPage::displayViewSourcePage() must implement interface Content, null given in /srv/mediawiki/php-1.31.0-wmf.4/includes/EditPage.php on line 763
[20:16:38] <no_justification>	 Ew
[20:17:41] <no_justification>	 stack: https://phabricator.wikimedia.org/P6196
[20:41:07] <tgr>	 no_justification: see earlier comments on https://gerrit.wikimedia.org/r/#/c/385946/
[20:43:03] <no_justification>	 Hm?
[21:44:38] <bd808>	 no_justification: https://gerrit.wikimedia.org/r/#/c/386689 is close but not quite right for the exception bit
[21:46:28] <no_justification>	 Replied on ticket
[21:58:00] <legoktm>	 no_justification: is there a task for the EditPage fatal? I could look into it
[21:59:27] <no_justification>	 Not yet
[21:59:30] <no_justification>	 I just spotted earlier
[21:59:34] <no_justification>	 Today's been hectic