[00:02:47] anomie: just upload your patch without them and use a common topic for reviewers to find? [00:16:30] bd808: added invalidation in https://gerrit.wikimedia.org/r/#/c/392993/2 so it's on parity with before [00:18:24] AaronSchulz: fancy! [00:18:45] I was kind of wondering if there was a good way to do that [00:18:57] many:1 is easy [00:19:11] funny, I've been thinking about many:many a lot lately [00:19:18] does a check key end up being a version counter basically? [00:20:00] a float timestamp that gets bumped [00:20:08] *nod* [00:20:13] (for all DCs) [00:20:37] and then the other keys get appended/prepended with it I guess [00:21:08] * bd808 should read the code at some point but is lazy [00:22:26] the meaningful key and the check key are checked via multi-get as a pair and there timestamps are compared (account for lag and some skew) [00:22:58] so if 10,000 things use X, they can use the check key for X, which is bumped on change [00:23:41] bd808: heh, I just realized you can't delete them ;) [00:24:11] interesting. I built something similar at Kount, but using it was 2 round trips. One to get the current version counter and then another to get the 'real' key with the current version embedded [00:24:35] well, you can edit them, so same difference [00:24:51] delete is still an open feature request, but you can edit literally all the parts I think [00:24:58] (throttle overrides that is) [00:25:01] yeah [00:26:52] I've been thinking about the wikidata type reference ball of many to many [00:32:01] Ugh. Yay an extension for config cuz we can't be bothered to finish real config [00:32:11] Real cfg mgmt [00:32:24] But hey, I guess the overhead of merging throttle rules is a lot [00:34:26] I volunteer to merge every throttle request if it means we can avoid adding a new extension! [00:36:19] I think the problem is mostly the timing - often people don't know their IPs until they are physically at the venue [00:36:32] And deployers don't want to be around 24/7 to push these out [00:36:57] I'll volunteer to be on call 24/7/365 [00:37:24] Again to avoid an extension [00:39:45] addshore: Curious on your thoughts about this approach to the hosts file issue - https://github.com/addshore/mediawiki-docker-dev/pull/30 [00:40:01] Next step after this is the Travis Ci build, which I'd really like to submit so that we can test things after that [00:40:07] It just seems rather silly to introduce a whole extension and new dB table just for a single config override [00:40:45] I proposed using a wiki page [00:41:16] https://phabricator.wikimedia.org/T174895 I think it'll be significantly less maintenance that way [00:41:25] and easier to migrate to future config mgmt system [00:43:14] One of these days you and I will come up with extra hours in a day and finish that [00:43:58] it's mostly why I was trying to make edit page suck less [00:44:04] many extra hours :D [00:44:04] Sadly "extend day to 28 hours" has a number of blockers [00:49:34] aaand it's a holiday now. /me afk, have a happy holiday if you're celebrating it :-) [00:50:22] * no_justification shall be deploying stuff while it's nice and quite :p [00:56:11] legoktm: Oh, deploying your keys fixes [00:56:15] {{done}} [12:48:38] Anyone want to merge https://gerrit.wikimedia.org/r/#/c/392220/ for me? [12:48:53] StatusValue::$ok is protected. lol [12:53:09] Awesome [12:53:15] in extension.json [12:53:15] "requires": { [12:53:15] "MediaWiki": ">= 1.23.0" [12:53:15] }, [18:57:47] Krinkle: I like the patch :) [18:58:06] infact, I just merged it [19:21:21] evening DanielK_WMDE_ [19:21:24] happy thanksgiving!