[00:00:09] brion: thanks for filing the RfC, I commented on the task :D [00:00:18] great :D [00:22:46] Reedy: You working on auto-registration of the DonationInterface unit tests or should I? (Not that it'll go into production before the New Year, but… ;-)). [00:22:53] Haha [00:22:58] I was just about to have a look [00:23:37] * James_F leaves it to the expert then. [00:23:59] "expert" [00:26:04] James_F: DonationInterface has them already in tests/phpunit [00:26:32] Just the hook to kill? [00:26:34] * Reedy pokes [00:26:36] Sounds like. [00:27:15] And donatewiki is on recent MW... [00:27:34] Are FR using REL1_27 and master of DonationInterface? [00:27:50] https://github.com/wikimedia/mediawiki/tree/fundraising/REL1_27 [00:36:01] Oh good heavens. [00:56:35] Hm.. Where does the fundraising branch run btw? It's not donatewiki (that's much newer than fundraising branches), then which wiki? [00:56:53] I've known about the branches for ages, but never actually figured out where they are used. [00:59:11] Ah, it's fundraising.wikimedia.org [00:59:14] https://wikitech.wikimedia.org/wiki/Fundraising.wikimedia.org [01:33:07] James_F: https://gerrit.wikimedia.org/r/#/c/393697/ [01:33:10] RESOLVED WFM? :P [01:33:23] 01:07:53 OK (1003 tests, 10225 assertions) [01:33:28] * Reedy makes a test change to see [01:37:00] Reedy: does it auto find in REL1_27 too? [01:37:08] I'm not sure [01:37:16] let's see [01:37:56] https://gerrit.wikimedia.org/r/#/c/302944/ [01:38:09] REL1_28 [01:38:18] bad legoktm [01:38:51] but [01:38:52] [00:34:04] heh, thanks for asking [01:38:52] [00:34:22] I think we just use that to conditionally add classes to the autoloader [01:38:52] [00:34:32] since we delete the tests dir for deploy [01:56:18] Reedy: uhoh, what did I do :o [01:56:38] it should be trivial to backport I think [02:10:43] brion: Oh my - https://phabricator.wikimedia.org/T2111 [02:10:49] An open bug from sourceforge time. [02:16:25] hah [02:44:24] legoktm: I don't know if we need to really... [02:45:56] https://gerrit.wikimedia.org/r/#/c/393704/ it does trivially cherry pick though :P [04:41:52] Reedy: o.O the Babel tests are failing?? [04:52:19] Could use input on https://gerrit.wikimedia.org/r/#/c/393713/1 - issue with how $IP is set. [15:59:14] legoktm: babel by itself on REL1_27 passes... https://gerrit.wikimedia.org/r/#/c/393783/ [20:04:13] bd808: I asusme you already ran https://gerrit.wikimedia.org/r/#/c/387516/ right? [20:07:55] legoktm: yes. I've used it to send 2 batches of 1300 emails each [20:08:02] seems to work as I'd hoped :) [20:10:24] legoktm: is there a place on mw.o or elsewhere that we write up things in wikimedia-maintenance? It seems like I should document that the script exists somewhere [20:11:33] bd808: probably something like https://wikitech.wikimedia.org/w/index.php?title=Addwiki.php&redirect=no ? [20:12:49] Yeah I can do something like that. I need to make a page about running the annual survey too in the hope that someday I'm not the one who does it :) [21:01:52] :( [{exception_id}] {exception_url} BadMethodCallException from line 444 of /srv/mediawiki/php-1.31.0-wmf.10/includes/logging/LogPager.php: Call to a member function bitAnd() on a non-object (null) [21:15:00] T181565 filed w/ stacktrace [21:15:01] T181565: Call to a member function bitAnd() on a non-object (null) in LogPager - https://phabricator.wikimedia.org/T181565 [21:20:27] anomie: Could you do a final review for https://gerrit.wikimedia.org/r/#/c/393673/ ? [21:21:30] Krinkle: Ok, but probably not today. [21:21:57] That's alright. It's not a rush.