[04:30:22] <legoktm>	 tgr: MaxSem: please review/expand https://www.mediawiki.org/wiki/Manual:Shell_framework :)
[04:32:26] <tgr>	 nice
[06:32:08] <legoktm>	 tgr: people shouldn't need to call ->setLogger( LoggerFactory::getInstance( 'shell' ) ) directly, it automatically gets injected
[06:33:09] <tgr>	 I wanted an example of how you can change it
[06:33:24] <tgr>	 but then forgot to delete it when I moved it into a separate section...
[19:16:27] <anomie>	 greg-g: Thoughts on enabling longer comments (edit summaries) on mediawiki.org and/or test wikis, since it's fundraising season? It has already been on in Beta Cluster for a while without issue. Worst case, if something breaks the config change can be reverted.
[19:17:41] <greg-g>	 anomie: it's been a long time coming. Prod DBs are ready I presume? :)
[19:17:54] <no_justification>	 I'm totally on board for testwikis
[19:18:01] <no_justification>	 mw.org...maybe
[19:20:51] <anomie>	 greg-g: Prod DBs on s3 are ready (mediawiki.org and testwikis are all on s3), as is s6. s2 is in progress, s1, s4, and s7 are pending, and s5 is blocked until January. ETA for completion of s5/s8 is mid-February. But it'd be nice to start the gradual rollout now.
[19:21:11] <anomie>	 Oh, and all DBs in codfw are done already.
[19:21:19] <anomie>	 except s5.
[19:21:43] <greg-g>	 let's do testwikis for now.
[19:21:48] <anomie>	 (T174569 is the tracking task for the schema change)
[19:21:50] <stashbot>	 T174569: Schema change for refactored comment storage - https://phabricator.wikimedia.org/T174569
[19:27:11] <no_justification>	 anomie: If you want to turn it on for some non-editing wikis, use closed.dblist. Then you get the feeling of Progress(tm) without actually doing much ;-)
[19:27:40] <anomie>	 no_justification: Wouldn't help too much, except to maybe catch read-only SQL queries that break.
[19:27:43] <no_justification>	 I know ;-)
[19:27:56] <no_justification>	 But then you get to say "Hey we finished 170+ wikis!"
[19:27:58] <no_justification>	 heheehehehe
[19:28:38] <no_justification>	 private.dblist might be good options
[19:28:44] <no_justification>	 Low impact if it breaks, but gets you some editing/testing
[19:33:02] <anomie>	 Whee, https://test.wikipedia.org/w/index.php?title=User:Anomie/Sandbox&action=history
[19:34:51] <MatmaRex>	 that's lit
[20:01:14] <Krinkle>	 no_justification: closed wikis are not actually closed.
[20:01:15] <Krinkle>	 :P
[20:01:27] <Krinkle>	 or at least not read-only.
[20:02:33] <Krinkle>	 user prefs are still mutable, as well as patrolling and various other log-producing events, and of course for stewards, global sysops and anyone else with an inherited plain 'edit' right from a non-local group can edit. E.g. interface editors.
[20:02:56] <Krinkle>	 Which I use sometimes to fix privacy policy or security issues in JS code on wikis, including "closed" ones
[20:03:20] <Krinkle>	 The only bugger is that if the wiki was closed before I ever logged in, I can't log in, because "closing" does shut off auto-create
[20:03:37] <Krinkle>	 So I can fix wikimania2011 but not 2008 :P
[20:04:19] <no_justification>	 I know they're not totally read-only, but they are for the most part other than minor maintenance here and there.
[20:04:34] <no_justification>	 Hence: good low-impact place to test changes rolling out and why I added them to group0
[20:05:04] <Krinkle>	 Ah, interesting.
[20:05:19] <anomie>	 And I had to revert. Breaks things that do cross-DB access, like CentralAuth and ForeignDBViaLBRepo.
[20:06:27] <no_justification>	 Hah
[20:22:12] <no_justification>	 Easy review: https://gerrit.wikimedia.org/r/#/c/395060/
[20:22:13] <no_justification>	 :)
[22:32:36] <TimStarling>	 I'll rebase my scripted change on top of Krinkle's @license change
[22:52:57] <Krinkle>	 TimStarling: stopped reviewing after I realised it was x/1045
[22:53:14] <Krinkle>	 Anyway, made a couple more tweaks in the parent patch. Guest the rest can just as easily happen afterward
[22:53:15] <Krinkle>	 sorry for the noise
[22:53:23] <Krinkle>	 I guess*
[22:53:26] <TimStarling>	 yeah, 1000 files
[22:53:59] <Krinkle>	 TimStarling: Can you check if @deprecated is/was used in any other file-level comment?
[22:54:11] <TimStarling>	 I did scroll through them all before I submitted, using a short context length, but I can't pretend to have spent very long looking at each one
[22:54:38] <TimStarling>	 yes
[22:58:06] <TimStarling>	 only includes/HtmlFormatter.php
[22:58:34] <legoktm>	 hm, that file should probably be in includes/compat/...
[22:58:43] <legoktm>	  * @todo: remove in 1.28
[23:00:49] <TimStarling>	 in other words, no, there are no other @deprecated comments in file comments that this script considers to be class files
[23:02:36] <legoktm>	 to avoid conflicts, I'll delete HtmlFormatter.php from core after your changes land
[23:05:49] <Krinkle>	 hehe
[23:07:04] <Krinkle>	 brion: nice RE: mp3. Is this in prep for a config switch, or is it to fill in blanks post-switch? E.g. are there non-mp3 files now on Commons that output <audio> with the mp3 transcode?
[23:07:21] <Krinkle>	 (given some have already been converted)
[23:07:32] <brion>	 Krinkle: config switch was already done along with the mp3 uploads
[23:07:42] <brion>	 this is back-filling the hojillion existing files :D
[23:07:47] <Krinkle>	 brion: right.
[23:08:04] <Krinkle>	 brion: This is no-js for mobile right? Or we have some minimal JS code for TMH/audio on mobile?
[23:08:06] <brion>	 browsers that grok ogg will see the ogg in all cases; browsers that grok mp3 but not ogg will see the mp3
[23:08:17] <Krinkle>	 What's the presedence order for the raw <audio> one?
[23:08:28] <brion>	 yes, we made one tiny tweak for the js mode so it sees mp3 before ogv.js 
[23:08:37] <Krinkle>	 Right.
[23:08:51] <brion>	 should be ogg > mp3
[23:08:52] <Krinkle>	 Doesn't <audio> support multiple sources/types natively, like for <video> though?
[23:08:57] <brion>	 exactly, it does
[23:09:00] <Krinkle>	 Right
[23:09:01] <brion>	 we output them all
[23:09:05] <Krinkle>	 so without JS we provide both and the browser picks
[23:09:06] <Krinkle>	 cool
[23:09:11] <brion>	 yep :)
[23:09:33] <Krinkle>	 brion: So this means no more ogv.js for audio?
[23:09:56] <brion>	 except in edge cases, like a broken or missing transcode, yeah
[23:09:57] <Krinkle>	 Or do we keep it for the js-enabled case if mp3 and ogg are both not supported in theory?
[23:10:05] <Krinkle>	 Ah, and that.
[23:10:12] <Krinkle>	 Oh, right, that's really nice
[23:10:14] <brion>	 :)
[23:10:24] <Krinkle>	 In case of tanscode wipes and fresh uploads.
[23:10:50] <Krinkle>	 brion: It seems right now for desktop we still default to ogv.js for browsers not supporting ogg
[23:11:08] <Krinkle>	 Or maybe that's just for missing transcode.
[23:12:16] <brion>	 i tested it locally, it did work once tweaked :D
[23:12:22] <brion>	 but yeah if transcode is missing it'll always load ogv.js
[23:12:39] <brion>	 it may also load some of the ogv.js loader early on if it sees ogg is not natively supported, i should check that
[23:12:45] <brion>	 (but it won't load the codecs until actually used)