[02:18:54] <Reedy>	 I wonder what travis on 7.2 will throw up
[02:19:00] <Reedy>	 I noticed numerous failures/errors on 7.1
[02:45:02] <legoktm>	 lots of warnings I expect
[02:54:17] <Reedy>	 41 errors
[02:54:35] <Reedy>	 34 failures
[03:03:02] <Reedy>	 legoktm: Know much about the hidedeprecated we have in phpunit tests?
[03:04:14] <Reedy>	 Actually, screw it
[03:04:17] * Reedy deletes
[03:44:13] <legoktm>	 Reedy: yes, it works but is kinda terrible
[03:44:27] <legoktm>	 it relies on the fact that wfDeprecated() will only warn once
[03:44:31] <Reedy>	 It doesn't seem to work in the setUp() of WatchedItem
[03:44:31] <Reedy>	 Ah
[03:44:35] <legoktm>	 so it does the warnings while suppressed
[03:44:36] <Reedy>	 I just nuked the lot of the tests
[03:44:36] <Reedy>	 https://gerrit.wikimedia.org/r/396299
[03:44:39] <Reedy>	 Deprecated since 1.27
[03:44:46] <Reedy>	 99.9% of usages in mw core tests
[03:44:53] <legoktm>	 then the code runs, and wfDeprecated() wont do anything
[03:45:25] <legoktm>	 Reedy: I assume you checked all the usage? 
[03:45:52] <Reedy>	 All usages in our hosted repos
[03:46:05] <Reedy>	 https://gerrit.wikimedia.org/r/396298 was the only one
[03:50:52] <Reedy>	 sorry addshore
[03:50:57] <Reedy>	 deleting ur hard work
[03:55:01] <legoktm>	 I'll merge the core one later tonight, I'm gonna be afk for a bit, just finished one of my final papers \o/
[03:56:24] <Reedy>	 woo
[03:56:27] <Reedy>	 glhf
[07:30:58] <addshore>	 Reedy: the whole point is they die :)
[13:58:44] <DanielK_WMDE>	 anomie: are you around? we seem to have an urgent performance issue with the api
[13:58:45] <DanielK_WMDE>	 https://phabricator.wikimedia.org/T182322
[13:59:32] <DanielK_WMDE>	 WMDE is heading out for the anual christmas party in an hour or two, and I'm on a train already, would be good to resolve that before...
[14:02:43] <anomie>	 DanielK_WMDE: Just got online. I'll look.
[14:04:33] <DanielK_WMDE>	 than you!
[14:04:37] <DanielK_WMDE>	 +k
[14:07:13] <DanielK_WMDE>	 anomie: addshore will be around for another hour, you can find him in #wikidata
[14:32:27] <addshore>	 o/
[15:18:22] <addshore>	 anomie: thoughts on the issue?
[15:19:22] <anomie>	 addshore: Still investigating. There doesn't seem to be any real "user related stuff", it's just whatever happens to first try to open a DB connection. The cpPosTime cookie seems likely to be related.
[15:27:23] <addshore>	 Yup
[15:28:24] <addshore>	 If it doesnt get 'fixed' ideally we would like them reverted and backported today, however everyone from the WMDE office is leaving for our christmas party imminently 
[15:40:09] <anomie>	 addshore: FYI, https://phabricator.wikimedia.org/T182322#3823259
[15:41:51] <addshore>	 Thanks anomie !
[19:04:41] <legoktm>	 TimStarling: re: GPL v2 section 2a, the FSF's GPL Compliance Lab said just adding "Copyright (C) 2017 Name" is the common practice
[21:49:46] <no_justification>	 Guess I'll tag 1.30 now :)
[21:49:53] <no_justification>	 I haven't seen any last minute complaints.
[21:50:08] <Reedy>	 no_justification: There.. was one
[21:50:29] <no_justification>	 It's not on the workboard
[21:50:40] <legoktm>	 the backport was already merged I think
[21:50:48] <Reedy>	 https://gerrit.wikimedia.org/r/#/c/396431/
[21:50:57] <Reedy>	 Ah, MatmaRex merged it
[21:51:03] <Reedy>	 Release-Notes up to date?
[21:51:04] <Reedy>	 I bet not
[21:51:27] <legoktm>	 also I fixed CI for REL1_30 so it should actually pass now
[21:51:31] <MatmaRex>	 D:
[21:52:02] <Reedy>	 https://github.com/wikimedia/mediawiki/compare/1.30.0-rc.0...REL1_30
[21:52:06] <MatmaRex>	 if there is some process for backporting things, please explain to me
[21:52:15] <no_justification>	 Basically jfdi
[21:52:16] <MatmaRex>	 because no one has ever been able to explain
[21:52:23] <MatmaRex>	 yeah that's what i always hear. okay
[21:52:26] <no_justification>	 There's no real official process
[21:52:28] <no_justification>	 Never made one
[21:52:33] <no_justification>	 Short of "propose it in gerrit"
[21:52:35] * no_justification shrugs
[21:52:36] <Reedy>	 As long as you're not doing big features etc
[21:59:03] <Reedy>	 https://gerrit.wikimedia.org/r/396531
[21:59:09] <Reedy>	 https://gerrit.wikimedia.org/r/396532
[22:01:38] <legoktm>	 is there a cake for the 30th version of MediaWiki?
[22:03:15] <Reedy>	 We've released many more than 30 versions ;)
[22:03:36] <legoktm>	 30th major* version!
[22:03:48] <Reedy>	 heh
[22:49:09] <no_justification>	 I think we're good?
[23:14:49] <no_justification>	 1.30.0 tag pushed
[23:26:18] <no_justification>	 Interesting, ./make-release.py 1.30.0 1.30.0-rc.0 gave me a release with no diffs
[23:26:34] <no_justification>	 Or wait, is .0 hardcoded for no patch?
[23:27:37] <no_justification>	 Ah, guess so!
[23:28:59] <no_justification>	 I guess we don't know what people are upgrading from, but could've sworn we did patches from final RC to final release
[23:30:57] <no_justification>	 Appears we don't. Ok fair 'nuff
[23:32:35] <no_justification>	 Files on releases.wm.o (well, one host, rsync might take a bit for the codfw mirror)