[02:32:54] <Reedy>	 legoktm: https://gerrit.wikimedia.org/r/#/c/398015/2/includes/registration/ExtensionProcessor.php Do we care if we modify the original array?
[02:39:40] <legoktm>	 Reedy: it should be safe to modify since $info isn't passed by reference right? in any case even if $info overall were modified it wouldn't make a difference
[02:40:17] <Reedy>	 ah, true, yeah
[02:40:25] <Reedy>	 So even less reason to use the temp variable
[03:14:08] <legoktm>	 https://github.com/squizlabs/PHP_CodeSniffer/pull/1724 <-- a sniff to detect when people have accidentally left git conflict markers in their code
[03:16:54] <Reedy>	 heh
[03:17:06] <Reedy>	 Is there cases where it'd actually be valid PHP, and not failing linting?
[03:17:18] <Reedy>	 I guess, if you ended up with <<<< in a multi line /* */
[03:17:33] <Reedy>	 +    }//end process()
[03:17:33] <Reedy>	  +}//end class
[03:17:36] * Reedy twitches
[03:17:38] <legoktm>	 when it gets stuck into comments I think
[03:18:02] <Reedy>	 Well, plus they're doing it in js and css too I guess
[03:23:17] <legoktm>	 https://github.com/squizlabs/PHP_CodeSniffer/issues/1783
[03:23:34] <legoktm>	 the next PHPCS release adopted a similar syntax to eslint for disabling/enabling rules for specific lines of code
[04:29:36] <Krinkle>	 legoktm: Does it have something like eslint-disable-next-line rule-name?
[04:29:55] <Krinkle>	 As alternative to disable/enable pairs (or trailing line comments, ugh)
[04:30:32] <legoktm>	 yep, // phpcs:ignore <Sniff.Code>
[04:31:07] <legoktm>	 https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.2.0 has a summary of the changes
[22:15:16] <no_justification>	 Booo :( [{exception_id}] {exception_url} MWException from line 644 of /srv/mediawiki/php-1.31.0-wmf.12/includes/logging/LogFormatter.php: Expected title, got null
[22:16:20] <no_justification>	 https://phabricator.wikimedia.org/P6467
[22:41:10] <no_justification>	 Also: Notice: Undefined variable: text in /srv/mediawiki/php-1.31.0-wmf.12/includes/parser/Parser.php on line 5774
[22:44:03] <subbu>	 that would be RoanKattouw's patch
[22:46:01] <no_justification>	 Also: Fatal error: Class undefined: MediaWiki\Linter\MissingCategoryException in /srv/mediawiki/php-1.31.0-wmf.11/extensions/Linter/includes/CategoryManager.php on line 144
[22:46:05] <no_justification>	 legoktm: ^^
[22:46:11] <no_justification>	 Oh, wmf.11. Is that fixed in wmf.12?
[22:46:48] <Reedy>	 MissingCategoryException wasn't autoloaded..
[22:47:10] <Reedy>	 It.. should be
[22:47:16] <Reedy>	 As it's PSR-4 autoloaded
[22:47:26] <subbu>	 no_justification, https://gerrit.wikimedia.org/r/#/c/393022/ fixed it i think
[22:47:49] <no_justification>	 Heh, indirectly my fault? :P
[22:49:00] <Reedy>	 https://github.com/wikimedia/mediawiki-extensions-Linter/commit/33dcc7211ea04c6c8b2e782381e7edb5daea5fc1
[22:56:35] <no_justification>	 Hmmm
[22:57:57] <Reedy>	 I'd suggest the undefined class should be fixed in .12, yes
[22:58:21] <no_justification>	 Surprise..... Notice: Undefined property: stdClass::$zoom in /srv/mediawiki/php-1.31.0-wmf.11/extensions/JsonConfig/includes/JCMapDataContent.php on line 127
[22:58:31] <no_justification>	 JsonConfig I </3 you