[12:02:09] <MaxSem>	 addshore: what am I doing wrong? https://en.wikipedia.beta.wmflabs.org/wiki/File:Explodeme.png :P
[12:02:26] <addshore>	 MaxSem: Huh? :P
[12:02:30] <addshore>	 re the bug i filed?
[12:02:34] <MaxSem>	 yup
[12:02:36] <addshore>	 (which one? ;)
[12:02:41] <MaxSem>	 doesn't explode for me
[12:02:53] <addshore>	 neither of them have a user facing explosion
[12:02:54] <MaxSem>	 https://phabricator.wikimedia.org/T183717
[12:03:33] <addshore>	 Yep, there is no output to the user, but the exception happens
[12:03:41] <MaxSem>	 meh
[12:03:51] <addshore>	 just managed to reproduce it locally too
[12:04:07] <MaxSem>	 anyway, GeoData just calls WikiPage::makeParserOptions()
[12:04:25] <MaxSem>	 so it's core that's broken
[12:04:51] <addshore>	 I think I need to apply a fix to Revision::newFromPageId similar to what is done in https://gerrit.wikimedia.org/r/#/c/399856/
[12:05:13] <addshore>	 should be easy to fix, especially as I can reproduce locally, and it should fix both tasks
[12:07:15] <MaxSem>	 MCR won't go live next week anyway
[12:07:29] <addshore>	 nope, i just checked ande the reverts still cleanly apply :)
[12:30:30] <addshore>	 bah, got it, it is atually an issue with RevisionStore::newRevisionFromConds
[12:31:40] <addshore>	 Infact, RevisionStore::loadRevisionFromConds
[19:19:38] <addshore>	 well legoktm I found the underlying issue causing lots of the things I have already patched in terms of MCR
[19:19:57] <addshore>	 if you have any review time I have a small clump of patches up
[20:16:54] <legoktm>	 addshore: the patch looks so simple :)
[21:25:44] <addshore>	 legoktm: indeed, shame it took me 5 days or something to finally dig there