[00:29:41] bd808: Bad news. You already are. ;-) [12:04:02] RoanKattouw: I was trying to remove a bunch of almost duplicate stuff from RevisionStore, we have methods that loads revisions by id and get passed a DB, and then methods that do the same and don't get passed a db. Was trying to cook up a way of leaving all of that behind in the compat layer in Revision. [12:05:08] If the method is called with a DB that is master, then pass READ_LATEST through to rev store, and if it is a slave, just READ_NORMAL.. I mean, there are some edge cases probably, an then daniel made the good point that the DB might not even be for the current wiki, bah [18:25:03] anomie: got an idea where the helper function for the itnerwiki user name should live? LogItem? RecentChange? User?... [18:25:37] Or Linker, even? [18:32:45] DanielK_WMDE: My first thought is User, as a static function taking two strings. Linker could make sense too. Doesn't really make sense to me in LogItem or RecentChange. [18:34:09] User sounds the most logical, though ideally, the User class would know nothing about how user names are encoded in different places. Oh, well. [19:40:22] brion: searching on wikimedia/* I found https://github.com/wikimedia/operations-debs-ffmpeg2theorawmf - is that still in use, or do we patch the non-suffixed package now? [19:40:25] (or neither?) [19:40:37] https://github.com/wikimedia/operations-debs-ffmpeg2theora [19:40:45] Krinkle: we no longer use ffmpeg2theora, so you can kill it [19:40:49] right [19:40:52] we did use a patched one for a while tho [19:41:24] I'll archive the repos as readonly after confirming there's no referneces in prod. [19:41:25] Thanks [19:41:29] not sure why we had two :D [19:41:34] k [19:41:44] it should be removed from puppet already but double-check :D [19:42:21] I also ran into jobqueue packages recently. Fun :D [19:42:54] https://phabricator.wikimedia.org/diffusion/ODCZ/ [19:43:20] *shudder* [19:45:33] brion: So this means we now either play WebM natively, or render client-side with ogv.js, is that right? [19:45:42] Krinkle: right [19:45:56] the webm plays a bit slower than the theora at the same resolution but it simplifies our pipeline a lot [19:46:01] ffmpeg2theora is buggy as shit [19:46:06] Edge 17 adds ogv support. [19:46:14] and webm! [19:46:19] Right [19:46:33] that'll leave just safari as the ogv.js target for modern browsers :D [19:46:38] Yeah, there's no ogv support without webm in any browser that I can see. [19:47:12] Does have a note about partial support, but I guess our case is covered? https://caniuse.com/#search=webm [19:47:16] for Edge [19:47:43] yeah, it's kinda funky [19:48:05] but with the web codec pack (now default with the upcoming windows 10, still optional in the current ver) it works fine [19:48:22] lot of asterisks on the earlier vers ;) [19:48:49] main remaining issue will be if we migrate to vp9, they only support it when it's hw-accel [19:48:58] so need to keep vp8 around too [19:49:45] Right [19:50:02] ooh that owasp preso is now *tunes in*