[19:20:04] anomie: <3 for https://phabricator.wikimedia.org/T183313#3910304 [21:05:59] Reedy: Always a pleasure working with you. ;-) [21:06:14] heh [21:06:24] I'm amused it's been there but unused for a year... [21:08:51] Two years. [21:09:05] Oh god, it's 2017 [21:09:06] *2018 [21:09:07] ffs [21:09:08] * Reedy cries [21:11:57] * James_F hugs Reedy. [21:24:41] Krinkle: lol [21:24:41] https://gerrit.wikimedia.org/r/405072 [21:25:01] Why didn't jerkins catch that in https://gerrit.wikimedia.org/r/405072 ? [21:25:06] in https://gerrit.wikimedia.org/r/#/c/375931/5 [21:27:58] Reedy does jenkins lint the files? [21:28:09] paladox: It's not a linting problem [21:28:13] The syntax is valid [21:28:17] It seemingly didn't run the tests [21:28:24] Oh i see [21:28:31] waiting to see what recheck does [21:28:45] And if that passes.. I'll make a commit to make it run the tests as is [21:29:20] (to check) [21:29:24] https://phabricator.wikimedia.org/T185260 filed [21:53:00] recheck passed [21:53:08] So obviously we run tests slightly differently... [22:47:16] tgr: Do you care about your sandbox/tgr/loop-debug branch on IPSet? [22:48:06] Reedy: I have no clue what that was so I guess that's a no [22:48:25] https://github.com/wikimedia/IPSet/commit/1e9b0028d219c7d4730a390f4e7804e647b1a545 [22:48:27] all of the debug :) [22:48:29] there was some stack overflow bug but I think it got fixed eventually [22:49:03] would sure have been nice of me to add a bug number [22:51:05] T126495 probably [22:51:06] T126495: IPSet::__construct() in gets into infinite loop when called from curl on a CI host - https://phabricator.wikimedia.org/T126495 [22:51:14] so yeah, feel free to nuke it [22:58:05] cheers [23:05:13] https://gerrit.wikimedia.org/r/#/c/405068/6/composer/installed.json [23:05:19] So much nicer on newer composer [23:40:01] * James_F sows worry and angst: https://gerrit.wikimedia.org/r/#/c/405216/ [23:44:41] https://gerrit.wikimedia.org/r/405217 [23:56:52] * bd808 realizes that core requiring 7.0 is going to make Toolforge look even more crusty and out of date :/ [23:57:01] E_TOOMANYTHINGS [23:57:10] bd808: Yeah… [23:57:56] we have vague plans. maybe Q4 will make them less vague [23:57:58] Reedy: We should also tweak the version check error message that suggests using `php5`. ;-)