[18:49:15] new librarization; https://gerrit.wikimedia.org/r/405914 [19:05:12] legoktm: Just to be difficult, but is there a reason we don't create those via a `git filter-branch`? [19:05:45] It'd preserve authorship/blame and give some context to "why is this line like this?" head-scratching in future. :-) [19:05:53] No reason besides we've never tried I think [19:06:05] For ObjectFactory it would work [19:06:07] I can try to do it if you want. [19:06:10] sure [19:06:20] (We did it for VE-core and OOUI.) [19:06:59] I'm curious to see how well it would work for things like bagostuff which has been moved all around MediaWiki [19:07:48] Yeah, --follow can only go so far. ;-) [19:31:13] bd808: legoktm: Should be properly archive https://github.com/wikimedia/generator-wikimedia-php-library ? [19:31:28] (and point to its replacement) [19:31:53] also, it seems the cookiecutter tool repo isn't replicated to Phab nor GitHub [19:31:56] getting 404 [19:33:23] yes [19:33:30] I thought I set up Phab replication? [19:37:46] legoktm: Hm.. yeah I see the repo [19:37:49] from the mediawiki.org doc link [19:37:55] but diff links from Gerrit do't work [19:37:57] eg. https://phabricator.wikimedia.org/rMCCL92d86aa23d86d740682ee334d78fa25ab6be6a9d [19:38:03] from https://gerrit.wikimedia.org/r/#/c/405919/ [20:12:41] legoktm: BTW, "Rewrite 0da76794566d5e4a9990b186e3bc8a9ac98d9979 (12038/80609) (1608 seconds passed, remaining 9159 predicted)" (on the first re-write to move the two files into a new subdirectory called ObjectFactory, then I have to re-run to collapse down to just that one. Yay. [20:13:48] woot [20:17:43] It's almost like MW-core has a lot of commits. :-) [20:36:11] Krinkle: do you want to make RFC for the user agents thing? Or should I make one? [20:42:17] SMalyshev: About whether to do it, or about how to do it? [20:42:27] I think the how can be resolved within CR [20:42:50] how to do it. I don't think whether is questionable? [20:43:43] I think it should be documented *somewhere* how one should do the user agents [20:44:01] as for where the somewhere is, I don't have much clue [20:44:56] as we add more stuff to mediawiki, we probably will have more http client things, and having them using consistent agents is good [23:15:42] https://gerrit.wikimedia.org/r/#/q/topic:missing-covers+status:open easy reviews :) [23:19:18] legoktm: Now "Rewrite 0d03983dfa906b2da7bc0e53c667978e960ddad2 (53933/80609) (12850 seconds passed, remaining 6355 predicted)" :-( [23:20:34] oh gosh [23:21:01] Yeah. [23:21:04] * James_F sighs. [23:37:51] MaxSem: the test for ApiQueryExtracts::getAllowedParams looks really silly [23:59:36] phew, not mine :P [23:59:37] https://github.com/wikimedia/mediawiki-extensions-TextExtracts/commit/6bfe60508a7782b04a7db38782af208b61e65e0f#diff-8815bf7e8909b73686ec8442f4b6c731