[05:23:12] <subbu>	 TimStarling, the html formatter dom serializer seems to escape more entities in html attributes than the sax one .. but otherwise, looks fine.  King's_Lynn vs King&amp;apos;s_Lynn
[05:23:32] <subbu>	 alright, bed time. ttyl.
[06:37:52] <legoktm>	 Krinkle: https://phabricator.wikimedia.org/T186300 is a random idea I had
[16:19:09] <anomie>	 no_justification: FYI, if you see deprecation warnings for "ParserOutput stateful (allowTOC|enableSectionEditLinks)" with the next train, ping me.
[16:20:12] <no_justification>	 I don't watch the deprecation log on trains typically... 
[16:29:11] <anomie>	 Oh, usually you're the one in here pinging about warnings.
[16:29:56] <anomie>	 Or are you saying deprecation warnings aren't in the log files you usually watch?
[16:31:29] <no_justification>	 Yep, not in my cornucopia of dashboards on train days
[16:41:59] <no_justification>	 anomie: I assume deprecation warnings are should fix, not must fix, so they're not exactly a priority on deployments
[16:42:00] <no_justification>	 :)
[19:56:33] <legoktm>	 anomie: is the preferred capitalization "LuaSandbox" or "luasandbox"?
[20:01:01] <anomie>	 legoktm: For the PHP extension? I'd guess LuaSandbox, although I usually wind up calling it php-luasandbox to avoid confusing it with the "LuaSandbox" classes or general feature in Scribunto.
[20:18:32] <legoktm>	 anomie: yeah, for the wiki page and phab project
[20:25:23] <tgr>	 anomie: https://www.mediawiki.org/wiki/Manual:SessionManager_and_AuthManager/Updating_tips#Starting_a_session_(wfSetupSession()) says
[20:25:26] <tgr>	 Note that old code would often do if ( session_id() !== '' ) { wfSetupSession(); }. This may be replaced with simply $session->persist().
[20:25:58] <tgr>	 is that correct? the old code seems to mean something like "if the user has a session, make it available" and the new could causes a session to be always created
[20:26:48] <tgr>	 ...new code...
[20:27:43] <anomie>	 tgr: That "!==" may be a typo.
[20:32:12] <anomie>	 e.g. https://gerrit.wikimedia.org/r/#/c/243223/58/includes/actions/SubmitAction.php
[21:02:52] <Krinkle>	 Would like CR on simple patches https://gerrit.wikimedia.org/r/#/c/407765/ and https://gerrit.wikimedia.org/r/#/c/407767/  :-) (replacing deprecated caller)
[23:16:43] <tgr>	 I would have expected something more impressive now that gerrit uses HTML emails
[23:16:51] <tgr>	 diff colors, at least
[23:22:59] <James_F>	 tgr: Label colours are the only change, AFAICT.
[23:24:51] <tgr>	 well, bolding and monotype and whatnot
[23:25:25] <tgr>	 it's not bad, it's just... unambitious
[23:27:11] <Krinkle>	 legoktm: What's the index time on codesearch? Is it a periodic cron? Or some other loop or react?
[23:27:24] <Krinkle>	 e.g. when can I expect a merged change to be reflected in results.