[01:25:12] does wikibase have some kind of anti-PSR policy? [01:25:39] it's like someone took the namespace/directory pairs and put them through a blender [01:25:51] extremely unfun to read the code without an IDE [01:30:42] uh, it used to use a psr-4 autoloader so I think most of the classes follow that? or did you mean something else? [01:54:10] I'm trying to follow some calls in github and so far every second class or so is in the wrong place [01:57:26] for example, some files in lib/includes/Store are under \Wikibase, others under \Wikibase\Store, yet others under \Wikibase\Lib\Store [01:58:02] I guess you could map all those namespaces to the same dir and be technically PSR-4 compatible, but... [08:32:42] TimStarling: is there a TechCom IRC office hour today? [15:31:28] Technical Advice IRC meeting starting in 30 minutes in channel #wikimedia-tech, hosts: @addshore & @Lucas_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [16:36:43] greg-g: I re-enabled the comment table in write-both mode on test wikis yesterday, no problems so far. Any thoughts on which wikis I should do next, and when? [16:49:29] anomie: was there a roll out plan with some CLs? [16:49:41] community liaisons* [16:49:50] No [16:50:10] that's more of a question for them than me I'd assume, right? [16:51:00] It's mostly a backend change anyway, the only user-visible difference is the ability to use longer edit summaries (and code for that in the web UI hasn't even been done yet). [16:52:09] it's a user facing feature: longer edit summaries, if you're asking for what wikis *technically* should be tested against, I think that's something you could answer better? if it's which would be willing to adopt/test now, CLs :) [16:55:48] sorry to deflect, in a meeting so that's where my mind goes :P [16:58:05] So far I'm not impressed with the CLs handling of TemplateStyles, and for this change I really don't care at all whether anyone actually uses longer edit summaries or not. What I care about is starting to use the new schema to see if there are bugs or performance issues, then running the maintenance script and getting to the point where the old schema could be dropped. [16:58:42] (TemplateStyles still probably needed to be done with CL input, even though it has taken way too long to get to where we're at so far) [17:47:22] anomie: I guess the big test would be a wiki like chinese wikipedia, right? They're also relatively up for testing new features earlier than others. Having a contact/someone to monitor their VP/T would be good though. [17:50:41] I think tomorrow morning I might do mediawiki.org and meta to get some traffic going to the new schema. [17:51:16] * greg-g nods [17:51:25] that is a wise next step [17:52:25] I'll be looking for errors or slow DB queries from the changed requests for the new schema. [20:37:18] Warning: Revision::ensureTitle: Could not determine title for page ID 7435706 and revision ID 91473347 [Called from Revision::ensureTitle in /srv/mediawiki/php-1.31.0-wmf.17/includes/Revision.php at line 548] in /srv/mediawiki/php-1.31.0-wmf.17/includes/debug/MWDebug.php on line 309 [20:37:28] I saw in wmf.17, I think its still in wmf.20 [20:43:58] [{exception_id}] {exception_url} BadMethodCallException from line 77 of /srv/mediawiki/php-1.31.0-wmf.17/extensions/CategoryTree/ApiCategoryTree.php: Call to a member function getDBkey() on a non-object (null)