[02:58:58] <tgr>	 legoktm: SoS mentions "@covers tags for extensions", what does that mean exactly?
[05:34:17] <legoktm>	 tgr: https://gerrit.wikimedia.org/r/#/q/topic:missing-covers :)
[05:34:29] <legoktm>	 tgr: Also I'm going to set up phpunit-patch-coverage for extensions too
[05:35:24] <tgr>	 cool
[07:10:30] <Krinkle>	 tgr|away: TimStarling: no_justification: Could you confirm that we do (indeed | still) want to stop php error propagation in wmf prod from mediawiki to hhvm? https://phabricator.wikimedia.org/T45086 / https://gerrit.wikimedia.org/r/#/c/338911/
[07:10:49] <Krinkle>	 I'm not sure if the duplication right now is in any way useful, e.g. or separation of concerns or something with how we view logstash or anything like that.
[07:11:43] <Krinkle>	 Separating mw errors from php errors seems useful, on the other hand, logging php errors from within mw means we get stacktraces (yay), and we already separate them with a channel (channel:error), so it should be fine?
[17:46:31] <anomie>	 legoktm: FYI, https://www.mediawiki.org/wiki/LuaSandbox
[19:28:57] <tgr>	 Krinkle: yeah, I think we do, as you said
[19:29:12] <tgr>	 the way hhvm logs PHP errors is not really useful
[19:29:23] <tgr>	 I'll rebase the patch and add release notes
[19:48:37] <no_justification>	 Krinkle: Yes. It's not terribly useful as-is :)
[19:48:54] <no_justification>	 Considering we mostly build dashboards with hhvm + mw.....you just end up duplicating
[20:11:08] <Krinkle>	 no_justification: tgr: Thanks, wanted to be sure.
[20:11:21] <Krinkle>	 Landing now.
[20:11:29] <Krinkle>	 Can one of you enable in beta cluster soon?
[21:08:07] <legoktm>	 anomie: oh, awesome :D
[22:28:09] <no_justification>	 Warning: Division by zero in /srv/mediawiki/php-1.31.0-wmf.20/vendor/wikimedia/running-stat/src/Wikimedia/PSquare.php on line 159
[22:28:14] <no_justification>	 Starting with wmf.20