[00:27:43] * legoktm hugs bd808
[00:27:59] <bd808>	 I'm looking at the code too :)
[00:28:58] <bd808>	 there is an open PR for non-master branches -- https://github.com/etsy/hound/pull/275
[00:30:05] <bd808>	 there is some sadness on that PR about hound's core maintainer status
[00:30:41] <bd808>	 heh. you are already ahead of me there
[00:32:33] <subbu>	 Krinkle, TimStarling fyi .. ruwiki said we don't need to revert remex to tidy since it is not critical .. since i said we can probably fix this in 2-3 weeks.
[00:47:42] <legoktm>	 bd808: yeah, I set up a fork but I'm unsure of actually using it because I don't really want to end up maintaining this long term
[00:49:03] <subbu>	 legoktm, i put the parser tests patch back into wip since i am making more changes my looking for every comment that mentions Tidy and fixing the test and/or comment.
[00:49:06] <subbu>	 *by
[00:49:23] <subbu>	 i'll finish up that patch.
[00:49:25] <legoktm>	 ok :)
[00:51:03] <legoktm>	 subbu: once the core patch lands we may also need to update extensions https://codesearch.wmflabs.org/extensions/?q=html(%2Fphp)%3F%5C%2Btidy&i=nope&files=&repos=
[00:51:20] <subbu>	 it never ends, does it :)
[00:53:41] <legoktm>	 :))
[08:04:13] <Krinkle>	 no_justification: Hm.. phpdocs say SORT_STRING is the default and has long since been since PHP 5.2+ ; https://gerrit.wikimedia.org/r/#/c/413078/
[08:04:44] <no_justification>	 rvv
[08:05:36] <Krinkle>	 https://3v4l.org/lP3uu
[08:05:48] <no_justification>	 https://gerrit.wikimedia.org/r/#/c/413679/
[08:05:52] <Krinkle>	 Seems SORT_ doen't actually sort
[08:05:53] <Krinkle>	 thx
[08:06:06] <Krinkle>	 Hands up for PHP :)
[08:06:35] <Krinkle>	 I guess it's supposed to influence how it decides which of a duplicate value to remove...
[08:06:38] <Krinkle>	 Anyway
[08:09:59] <_joe_>	 Krinkle: what TZ are you in right now?
[08:10:16] <Krinkle>	 :|
[08:10:23] <_joe_>	 if you happen to be around UTC, I'll probably ask you to review a second patch to EtcdConfig
[08:10:28] <_joe_>	 else, go to bed :P
[08:10:47] <Krinkle>	 The I've-spent-too-much-time-at-IKEA-and-constructing-things-all-day-but-want-to-get-some-work-done timezone
[08:10:49] <_joe_>	 and you can take a look in the morning
[08:10:51] <Krinkle>	 Also known as UTC -7.104
[08:11:01] <_joe_>	 oh, I know the feeling
[08:11:36] <Krinkle>	 Yeah, I'll take a look at that in the morning/afternoon.
[08:11:43] <_joe_>	 yeah no rush
[08:11:57] <_joe_>	 monday or tuesday will be good as well
[08:12:23] <_joe_>	 I'm still trying to assess all failure scenarios adequately for now, patches are born from my tests :P
[08:14:00] <Krinkle>	 Col
[08:14:01] <Krinkle>	 Col
[08:14:03] <Krinkle>	 Cool *
[08:14:19] <Krinkle>	 btw, this php version bisect is really messed up; https://3v4l.org/0Jeva
[08:15:36] <Krinkle>	 Behaviour that was constant from PHP4 all the way to PHP7.0, but broken/fixed multiple times, in minor releases PHP 4.3.0-4.3.9 and PHP 5.0.1-PHP5.0.2, has now been changed to the 'broken' variant in PHP 7.2
[08:15:41] <_joe_>	 ahah
[08:15:55] <_joe_>	 and hhvm > 3.20
[08:16:28] <Krinkle>	 Yeah, it was considered a bug in PHP 4.3.x for a short time, and again in PHP 5.0.x, but then now.. they changed their mind
[08:18:19] <_joe_>	 what's the script I have to use to write php interactively in "mediawiki context" ? 
[08:18:33] <_joe_>	 eval.php or something, I have a brainfart
[08:18:37] <_joe_>	 well, I'll find it
[08:19:19] <legoktm>	 yes eval.php
[08:19:32] <legoktm>	 also shell.php is a more modern version that supports pasting in unicode characters for one
[08:19:34] <_joe_>	 mwscript maintenance/eval.php right?
[08:19:38] <_joe_>	 oh ok
[08:19:41] <_joe_>	 so shell.php?
[08:19:42] <legoktm>	 just mwscript eval.php will work
[08:19:50] <legoktm>	 s/eval/shell/
[08:20:16] <_joe_>	 thanks
[15:21:25] <anomie>	 Amir1: FYI, I reopened T183019. It looks like the code fix will work once the SiteLookup configuration is fixed. But perhaps the missing SiteLookup configuration should be an error instead of silently falling back to the broken behavior.
[15:21:25] <stashbot>	 T183019: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5) - https://phabricator.wikimedia.org/T183019
[15:41:40] <Amir1>	 anomie: Okay, I take a look, it might be a problem in the code
[15:41:59] <Amir1>	 we should be able to get interwiki 
[15:43:47] <anomie>	 Amir1: It looks like the problem is that the site_identifiers tables haven't been being updated.
[17:45:54] <James_F>	 anomie: How lame; the only rebase conflict for your actor table patch is a change to the tests to use implode() rather than join().
[17:46:33] <anomie>	 For some reason I probably use join() rather than implode() all over the place.
[17:46:55] <James_F>	 Yeah, but now we have a sniff that enforces implode(), it seems.
[17:47:00] <James_F>	 Consistency isn't terrible.
[17:48:38] <anomie>	 Yeah, I won't fight it. I'll just grumble to myself every time the sniff hits until I change my habits.
[17:49:51] * James_F grins. Anyway, patch rebased.
[17:50:27] * anomie just got to the email in his inbox that says Tim +1ed
[17:53:05] <James_F>	 Always happy to help push things through.
[20:34:49] <no_justification>	 Ugh I hate proofread pages: [{exception_id}] {exception_url} MWException from line 60 of /srv/mediawiki/php-1.31.0-wmf.21/extensions/ProofreadPage/includes/Index/EditIndexPage.php: EditIndexPage is only able to display a form for IndexContent
[21:15:30] <Reedy>	 legoktm: Would using a string in class_exists instead off Foo::class be a useful sniff?
[21:41:14] <legoktm>	 Reedy: https://codesearch.wmflabs.org/search/?q=class_exists%5C(%20%27.*%3F%27%20%5C)&i=nope&files=&repos= I think so
[21:41:36] <Reedy>	 https://phabricator.wikimedia.org/T188144#3997673
[21:41:42] <Reedy>	 Just filed it already :P
[21:50:57] <DanielK_WMDE>	 anomie: hey - I saw you asking me some stuff about slot_inherited the other day, but I don't remember where.
[21:51:06] <DanielK_WMDE>	 can you give me a poinnter, so I can reply?
[21:51:49] <legoktm>	 DanielK_WMDE: your inbox
[21:51:50] <anomie>	 DanielK_WMDE: It was an email.
[21:56:02] <DanielK_WMDE>	 haha, that's why i can't find it on gerrit or pahb :)
[22:09:52] <DanielK_WMDE>	 ok, replied